Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: fixes to the dropdown buttons #831

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

afeld
Copy link
Contributor

@afeld afeld commented Apr 8, 2024

This pull request includes a handful of improvements around the drop-down/launch buttons:

  • Improves the interactivity of the drop-down buttons: Version 1.0.0 introduced a gap between the hover area and the drop-down. When the mouse would move from the former to the latter (especially if slowly), the drop-down would disappear. You can see this behavior on the live site. cc @choldgraf since you did work in this area.
  • Adds alt text to the launch button logos
  • Adds a space between "Launch on" and the tool name - fixes Typo in tooltip text of launchers #722 cc @rhugonnet

Screenshot showing "Launch on Colab"

Previously, there was a gap between the hover area and the drop-down. When the mouse would move from the former to the latter, the drop-down would disappear.
Copy link

welcome bot commented Apr 8, 2024

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@afeld afeld changed the title fixes to the dropdown buttons [FIX] fixes to the dropdown buttons Apr 8, 2024
@agoose77
Copy link
Collaborator

agoose77 commented Apr 8, 2024

@choldgraf LGTM, but do cast your eye over the SBT dropdowns for "Launch on"; I didn't author this originally, so I'm not familiar with whether this is a regression or a long-standing bug.

@afeld
Copy link
Contributor Author

afeld commented Apr 8, 2024

Looks like it was introduced with the translation in 1656b77#diff-c18ac40355c51c6c6566efc355dfa5e7f002859040252df71ebc2d3a01da96bcL115.

Copy link
Member

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great to me - I'm not sure what bug @agoose77 is pointing out, but I agree I don't think it's related to this PR.

I'll merge this one in, and @agoose77 if there's something you think is wrong, could you open an issue that describes it so we can spot-check in a follow up?

@choldgraf choldgraf merged commit b88f9a4 into executablebooks:master Apr 8, 2024
14 of 15 checks passed
Copy link

welcome bot commented Apr 8, 2024

Congrats on your first merged pull request in this project! 🎉
congrats

Thank you for contributing, we are very proud of you! ❤️

@agoose77 agoose77 changed the title [FIX] fixes to the dropdown buttons FIX: fixes to the dropdown buttons Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in tooltip text of launchers
3 participants