-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hooks #688
Add pre-commit hooks #688
Changes from 5 commits
9dcfff9
925d588
f81ebee
0e68c85
782067f
0c2ebef
3e0be71
d565cf2
a2b5772
12e36f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ on: | |
# every day at 1:00 | ||
- cron: '0 1 * * *' | ||
workflow_dispatch: | ||
|
||
|
||
jobs: | ||
docs: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Install pre-commit hooks via | ||
# pre-commit install | ||
|
||
exclude: > | ||
(?x)^( | ||
\.vscode/settings\.json| | ||
)$ | ||
repos: | ||
|
||
- repo: git://github.com/pre-commit/pre-commit-hooks | ||
rev: v4.1.0 | ||
hooks: | ||
- id: check-toml | ||
- id: check-json | ||
- id: check-yaml | ||
- id: end-of-file-fixer | ||
- id: trailing-whitespace | ||
|
||
- repo: https://github.com/psf/black | ||
rev: 22.1.0 | ||
hooks: | ||
- id: black | ||
|
||
- repo: https://github.com/executablebooks/mdformat | ||
rev: 0.7.13 | ||
hooks: | ||
- id: mdformat | ||
files: docs/* | ||
additional_dependencies: | ||
- mdformat-gfm | ||
- mdformat-myst | ||
- mdformat-black |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,4 +9,4 @@ ul.postlist > li > p:first-child { | |
|
||
.landing-grid .sd-card-header { | ||
background-color: #f3772638; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ This is open to anybody, and is a space where people can ask questions and help | |
Please feel free to provide support, advice, etc to anybody on this forum. | ||
|
||
(comms:issues)= | ||
|
||
## GitHub Issues | ||
|
||
For conversations around specific actions, tasks, features, etc, we use GitHub issues in each repository. | ||
|
@@ -25,6 +26,7 @@ If you'd like access, please reach out to a core team member to discuss! | |
|
||
% ref: https://github.com/executablebooks/meta/discussions/412 to share password/access | ||
|
||
We have an e-mail address at `[email protected]`. | ||
All core team members should have access to this email, though it is not currently actively monitored by the team. | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,54 +7,54 @@ computational narratives using the Jupyter ecosystem. | |
|
||
We are the community behind [Jupyter Book](https://jupyterbook.org)--an open source project for building beautiful, publication-quality books and documents from computational material--as well as [MyST Markdown](https://myst-parser.readthedocs.io/en/latest/)--a rich and extensible flavor of Markdown meant for technical documentation and publishing. | ||
|
||
::::{grid} 1 2 2 2 | ||
::::\{grid} 1 2 2 2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I updated the PR to add those plugins to our hook. Hmm - looks like it is not picking up the colon fence syntax, is there a way to tell the pre-commit hook to re-use the same plugins that are enabled in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. executablebooks/mdformat-myst#13 and executablebooks/mdformat-myst#9 But no, not presently 😢 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ah bummer - ok I'll just comment out the lines about mdformat and we can re-enable if/when there is support for extra myst extensions. |
||
:class-container: landing-grid | ||
|
||
:::{grid-item-card} | ||
:::\{grid-item-card} | ||
:padding: 2 | ||
For contributors 👩💻 | ||
^^^ | ||
Read our [Contributing Guide](contributing.md) to learn about the conventions we follow, and see [our community forum](https://github.com/executablebooks/meta/discussions) to ask questions and help others. | ||
::: | ||
|
||
:::{grid-item-card} | ||
:::\{grid-item-card} | ||
:padding: 2 | ||
Be inspired ✨ | ||
^^^ | ||
Our [Gallery of Jupyter Books](gallery.md) has contributions from across the community, and [our blog](updates.md) has updates from the community. | ||
::: | ||
|
||
:::{grid-item-card} | ||
:::\{grid-item-card} | ||
:padding: 2 | ||
Tools we build 👍 | ||
^^^ | ||
Our [Feature Voting board](feature-vote.md) is an easy way for community members to voice support for features and enhancements. Our [Tools Page](tools.md) also lists many of the tools we build to learn more. | ||
::: | ||
|
||
:::{grid-item-card} | ||
:::\{grid-item-card} | ||
:padding: 2 | ||
About the project ℹ️ | ||
^^^ | ||
Learn more about [our project's goals and strategy](about.md), see [a list of core team members](team.md), and see [our team meeting notes and calendar](meetings/index.md). | ||
::: | ||
:::: | ||
|
||
|
||
## Acknowledgements | ||
|
||
:::{image} https://pbs.twimg.com/profile_images/1226944724365447169/MzFpwY5P_400x400.png | ||
:::\{image} https://pbs.twimg.com/profile_images/1226944724365447169/MzFpwY5P_400x400.png | ||
:class: float-left mr-2 rounded | ||
:width: 100px | ||
::: | ||
|
||
The Executable Books Project is supported by several institutions and members of open source projects. | ||
In particular, many thanks to the [Sloan Foundation](https://sloan.org) which [provides support for the Executable Books Project](https://sloan.org/grant-detail/9231). | ||
|
||
|
||
```{toctree} | ||
:maxdepth: 2 | ||
:caption: Get Involved | ||
:hidden: | ||
--- | ||
maxdepth: 2 | ||
caption: Get Involved | ||
hidden: | ||
--- | ||
contributing.md | ||
developer.md | ||
resources.md | ||
|
@@ -63,17 +63,21 @@ meetings/index.md | |
``` | ||
|
||
```{toctree} | ||
:hidden: | ||
:caption: Our Projects and Tools | ||
--- | ||
hidden: | ||
caption: Our Projects and Tools | ||
--- | ||
feature-vote.md | ||
gallery.md | ||
tools.md | ||
``` | ||
|
||
```{toctree} | ||
:maxdepth: 2 | ||
:caption: About the Project | ||
:hidden: | ||
--- | ||
maxdepth: 2 | ||
caption: About the Project | ||
hidden: | ||
--- | ||
about.md | ||
team.md | ||
updates.md | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeh so you need to use this with plugins 😉 e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh ok, I will try to give that a shot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhhh, ok I will take a look and figure it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meaning to circle back to mdformat-myst at some point and do some more testing/improvements.
Would be nice to advertise it on jupyter-book (but only when I'm certain it is properly working)