TST: fail on warnings #647
Open
+29
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The configuration for failing on warnings is all OK, but the actual fix for the deprecation is a dead end currently as we run into a |
bsipocz
added
testing
|
For context and recent discussion about the deprecation and possible un-deprecation see sphinx-doc/sphinx#13083 |
bsipocz
force-pushed
the
TST_fail_on_warnings
branch
4 times, most recently
from
4605fe1
to
1b8a727
Compare
|
There are still tons of windows issues, and I have to rely on CI to get those sorted out, so I'm sorry for the upcoming flood of spammy notifications originating from this PR. |
…gets triggered with the used version combo
bsipocz
force-pushed
the
TST_fail_on_warnings
branch
from
21f1877
to
816ea29
Compare
|
@agoose77 - This is good to go. I fully expect this to provide a lot of help with picking up the compatibility issues early on, the ones we run into now after users report them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #645