-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
Wow, thanks! I won't be able to check this for a few more days; but, thank you very much for helping out 😄 Hold on a few more days! |
I'd like to get some specs working before I merge this in so we can be sure nothing breaks. |
Oh, wait... There already are some specs for |
Okay, I've read through your code. I'm not sure I like requiring that path matchers begin with slashes. I'll think about this. |
Oh, and please add tests to cover the new use cases |
IMO using Regex in config (not in implementation) for path matching is overkill. Utilizing bash glob or go filepath matching syntax would be better since we are dealing with files and more people are already use that syntax to match files. Also slash at the beginning would not be needed. I have added slash to avoid possible false positives with configs written for old versions ie.: 'r.*b.ext': 'source.ruby' # user used path unaware config
# would match: r/b.ext
# not just: rib.ext Will add tests ASAP (end of this week at latest). |
I'm open to the idea of bash globbing. As for v0.5.x, though, RegExp will stay. BTW, I just implemented the longest-match and tie-breaker logic, as well as deprecating extension matchers. Those changes conflict with this PR. Sorry for totally breaking your work effort... |
I've opened up #49 to talk about bash globbing 👍 |
I'm going to close this for now in favor of #51. |
Pull to #36 issue.
On Windows replace of
/
to\\\\
is done before matching.