Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Updates #374

Merged
merged 10 commits into from
Jan 22, 2024
Merged

Documentation Updates #374

merged 10 commits into from
Jan 22, 2024

Conversation

phil-6
Copy link
Contributor

@phil-6 phil-6 commented Jan 22, 2024

Pull Request

Summary:
Updates the docs to add new information from discussions

Description:
Simple changes to improve readability (mostly adding line-breaks)
Extra information around upgrading and new approaches.

Testing:
Only Changes to Docs

Checklist:

  • [ x ] Code follows the project's coding standards
  • [ x ] Tests have been added or updated to cover the changes
  • [ x ] Documentation has been updated (if applicable)
  • [ x ] All existing tests pass
  • [ x ] Conforms to the contributing guidelines

@excid3
Copy link
Owner

excid3 commented Jan 22, 2024

Couple small tweaks I made:

  1. cert_path should be under iOS
  2. Adjusted the to_prepare example to add a belongs_to :organisation and simplify it a bit.

@excid3
Copy link
Owner

excid3 commented Jan 22, 2024

Also showed that you can extend Noticed::Event as well.

@excid3 excid3 merged commit ba582bb into excid3:main Jan 22, 2024
45 checks passed
@phil-6
Copy link
Contributor Author

phil-6 commented Jan 22, 2024

Amazing, Thanks Chris! I was just about to add a note about Noticed::Event!

@phil-6 phil-6 deleted the Documentation-Updates branch January 26, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants