Display app version and created Dockerfile #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cDavies44
suggested changes
Jun 14, 2019
| color: white; | ||
| text-align: center; | ||
| margin-top: -50px; | ||
| } |
There was a problem hiding this comment.
Just a few things:
- Setting colors like "color" for text or "background-color" for background doesnt allow for angular material to automatically change based on light vs dark mode, so this should generally be avoided.
- To have the bottom bar dynamic change be handled by angular you can use a component, instead of a div https://material.angular.io/components/toolbar/overview. This is also a place where a toolbar may not be necessary, and just some color:grey text with the version number could work.
- having commented out code is generally frowned upon
There was a problem hiding this comment.
Yeah I wanted to do a toolbar at first but now I think the site looks a lot cleaner with just tge version number at the bottom right corner. I cleaned up that comment part. ty!
src/app/app.component.scss
Outdated
| width: 100%; | ||
| text-align: right; | ||
| margin-top: -50px; | ||
| <<<<<<< HEAD |
src/app/app.component.scss
Outdated
| <<<<<<< HEAD | ||
| font-size: 14px; | ||
| margin: -10px; | ||
| ======= |
src/app/app.component.scss
Outdated
| @@ -37,4 +49,5 @@ | |||
| cursor:pointer; | |||
| color:#e33e47; | |||
| font-family: $font-fam; | |||
| >>>>>>> 55d361138c1509cfaf9660405b770c48fc18c605 | |||
src/app/app.component.html
Outdated
| </div> | ||
| <ng-template #darkVersion> | ||
| <div class="footer"> | ||
| <p style="color: white">Version {{ getVersion() }}<p> |
There was a problem hiding this comment.
convention: all styling should be done in scss files. Classes should then be applied to HTML tags
There was a problem hiding this comment.
Got it. I will use a span tag instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.