#967: Added ctpg script options parser #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomuben
commented
Oct 1, 2024
redcatbear
requested changes
Oct 4, 2024
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/test/script_option_lines_test.cpp
Outdated
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/test/script_option_lines_test.cpp
Outdated
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Outdated
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Outdated
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.h
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Oct 7, 2024
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Oct 7, 2024
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Oct 7, 2024
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Show resolved
Hide resolved
tkilias
reviewed
Oct 7, 2024
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Show resolved
Hide resolved
redcatbear
previously approved these changes
Oct 8, 2024
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Outdated
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Show resolved
Hide resolved
tkilias
reviewed
Oct 8, 2024
tkilias
reviewed
Oct 8, 2024
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.h
Outdated
Show resolved
Hide resolved
tomuben
force-pushed
the
refactoring/967_add_ctpg_script_options_parser
branch
from
f156bf4
to
cc7e7d1
Compare
tkilias
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#967
Adds the CTPG based script options parser + Unit tests, but does not yet use the new parser in the Java VM of the UDF client.