Use std::unique_ptr for Parser

exasol · Sep 17, 2024 · e655e6e · e655e6e
1 parent 2e28783
commit e655e6e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/exaudfclient/base/javacontainer/script_options/extractor.cc b/exaudfclient/base/javacontainer/script_options/extractor.cc
@@ -28,8 +28,8 @@ Extractor::Extractor(const std::string & scriptCode, std::function<void(const st
 , m_jvmOptionKeyword("%jvmoption") {}
 
 
-ScriptOptionsParser* Extractor::makeParser() {
- return new ScriptOptionLinesParserLegacy();
+std::unique_ptr<ScriptOptionsParser> Extractor::makeParser() {
+ return std::make_unique<ScriptOptionLinesParserLegacy>();
 }
 
 void Extractor::extractImportScripts(ScriptOptionsParser *parser) {

diff --git a/exaudfclient/base/javacontainer/script_options/extractor.h b/exaudfclient/base/javacontainer/script_options/extractor.h
@@ -37,7 +37,7 @@ class Extractor {
 
  void extract();
  private:
- ScriptOptionsParser* makeParser();
+ std::unique_ptr<ScriptOptionsParser> makeParser();
 
 
  void extractImportScripts(ScriptOptionsParser* parser);

diff --git a/exaudfclient/base/javacontainer/script_options/parser_legacy.h b/exaudfclient/base/javacontainer/script_options/parser_legacy.h
@@ -16,10 +16,10 @@ class ScriptOptionLinesParserLegacy : public ScriptOptionsParser {
 
  virtual void parseForSingleOption(std::string & scriptCode, const std::string key,
  std::function<void(const std::string &option, size_t pos)> callback,
- std::function<void(const std::string&)> throwException);
+ std::function<void(const std::string&)> throwException) override;
  virtual void parseForMultipleOptions(std::string & scriptCode, const std::string key,
  std::function<void(const std::string &option, size_t pos)> callback,
- std::function<void(const std::string&)> throwException);
+ std::function<void(const std::string&)> throwException) override;
 
  private:
  const std::string m_whitespace;