📝 plugin: document no signature expiry

exactly · Jul 3, 2024 · 21fc6a2 · 21fc6a2
1 parent 9414ae9
commit 21fc6a2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.gas-snapshot b/.gas-snapshot
@@ -11,7 +11,7 @@ MultiOwnerPluginTest:testFuzz_userOpValidationFunction_BadFunctionId(uint8) (run
 MultiOwnerPluginTest:testFuzz_userOpValidationFunction_ContractOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 130908, ~: 130897)
 MultiOwnerPluginTest:testFuzz_userOpValidationFunction_ContractOwnerWithEOAOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 144523, ~: 144512)
 MultiOwnerPluginTest:testFuzz_userOpValidationFunction_EOAOwner(string,(address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 138777, ~: 138780)
-MultiOwnerPluginTest:testFuzz_userOpValidationFunction_PasskeyOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 373606, ~: 373621)
+MultiOwnerPluginTest:testFuzz_userOpValidationFunction_PasskeyOwner((address,uint256,bytes,bytes,uint256,uint256,uint256,uint256,uint256,bytes,bytes)) (runs: 256, μ: 373615, ~: 373631)
 MultiOwnerPluginTest:test_eip712Domain() (gas: 35438)
 MultiOwnerPluginTest:test_isValidSignature_failMalformedAddress() (gas: 15544)
 MultiOwnerPluginTest:test_isValidSignature_failWithOutOfBounds() (gas: 12319)

diff --git a/src/WebauthnOwnerPlugin.sol b/src/WebauthnOwnerPlugin.sol
@@ -333,6 +333,7 @@ contract WebauthnOwnerPlugin is BasePlugin, IWebauthnOwnerPlugin, IERC1271 {
     return keccak256(abi.encode(_TYPE_HASH, _NAME_HASH, _VERSION_HASH, block.chainid, account, _SALT));
   }
 
+  /// @notice Signatures are valid indefinitely.
   /// @dev Webauthn public keys with `y` as 0 are not supported, as they will be treated as Ethereum addresses.
   function _validateSignature(address account, bytes32 message, bytes calldata signature) internal view returns (bool) {
     PublicKey memory owner = _owners[account].get(uint8(signature[0]));