OTA needs to be after MDNS

ewowi · Nov 11, 2023 · 11db776 · 11db776
1 parent b419b4f
commit 11db776
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/src/Sys/SysModOTA.h b/src/Sys/SysModOTA.h
@@ -16,20 +16,31 @@ class SysModOTA : public SysModule {
 
 public:
     SysModOTA() : SysModule("OTA") {
-        this->isEnabled = false;
-        this->success = false;
+        this->success = true;
+        this->started = false;
     };
 
     void connectedChanged() {
         if(!SysModules::isConnected) return;
         ArduinoOTA.begin();
-        this->success = true;
+        this->started = true;
+        USER_PRINTF("ArduinoOTA.begin()\n");
      }
 
-    void loop1s() {
-        ArduinoOTA.handle();
-        this->isEnabled = true;
+    void loop() {
+        if(this->started) {
+            ArduinoOTA.handle();
+        }
     }
+
+    void loop10s() {
+        if(!this->started) {
+            USER_PRINTF("ArduinoOTA not started\n");
+        }
+    }
+
+private: 
+    bool started;
 };
 
 static SysModOTA *ota;
diff --git a/src/main.cpp b/src/main.cpp
@@ -94,7 +94,6 @@ void setup() {
   mdls->add(print);
   mdls->add(web);
   mdls->add(net);
-  mdls->add(ota);
   #ifdef APPMOD_LEDS
     #ifdef USERMOD_DDP
       mdls->add(ddpmod);
@@ -115,6 +114,7 @@ void setup() {
     mdls->add(wledAudioMod);
   #endif
   mdls->add(mdns); //no ui
+  mdls->add(ota); // OTA need to be called after MDNS
 
   //do not add mdls itself as it does setup and loop for itself!!! (it is the orchestrator)
   mdls->setup();