Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale to zero #436

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Scale to zero #436

wants to merge 3 commits into from

Conversation

davidkarlsen
Copy link
Collaborator

@davidkarlsen davidkarlsen commented Jun 5, 2022

both min and max can be set to zero.
Now GH waits for runners to appear with the labels, rather than failing because there are no available runners.

@davidkarlsen davidkarlsen changed the title this comment is no longer true Scale to zero Jun 5, 2022
@codecov
Copy link

codecov bot commented Jun 5, 2022

Codecov Report

Merging #436 (68daee3) into master (2c24a48) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   65.48%   65.48%           
=======================================
  Files           3        3           
  Lines         307      307           
=======================================
  Hits          201      201           
  Misses         80       80           
  Partials       26       26           
Impacted Files Coverage Δ
controllers/githubactionrunner_controller.go 58.11% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@davidkarlsen davidkarlsen force-pushed the feature/scale-to-zero branch 2 times, most recently from 69864f7 to eb5f4a4 Compare June 5, 2022 19:37
@davidkarlsen davidkarlsen force-pushed the feature/scale-to-zero branch from eb5f4a4 to 68daee3 Compare June 5, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant