fix crash with manual squads

eveseat · Dec 2, 2023 · 2f5076d · 2f5076d
1 parent 6ba895f
commit 2f5076d
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Models/Filterable.php b/src/Models/Filterable.php
@@ -51,9 +51,10 @@ abstract public function getFilters(): stdClass;
      */
     final public function isEligible(Model $member): bool
     {
-        // in case no filters exists, bypass check and return not eligible
+        // in case no filters exists, everyone should be allowed
+        // this is the case with manual squads
         if (! property_exists($this->getFilters(), 'and') && ! property_exists($this->getFilters(), 'or'))
-            throw new InvalidFilterException('root filter configuration is not a rule group');
+            return true;
 
         $query = new QueryGroupBuilder($member->newQuery(), true);