[WIP] Prototype of Everypolitician::Scraper class #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The moves the steps that are needed to actually get the data out of the scraper into a separate class, which can then be called when inserting into the storage.
Rather than hard coding the data pass it into the constructor.
We don't want to have to run the scraper repeatedly to do calculations on the results, so cache the result.
This was referenced Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prototype of the
Everypolitician::Scraperclass. It's a subset of the original change made in #7Notable differences from #7 are:
ScraperRunclass:configoptionScraperclass is now responsible for handlingindex_fields, since it needs the data to calculate this anyway.ScraperWiki), I think that will probably need to be done in a separate change.