s/slave/agent

[eherot]

Please don't merge this yet. It will break everything.

[jeffbyrnes]

@eherot I did some similar work on et_mesos_slave cookbook (which needs to be completely renamed).

[jeffbyrnes]

Said work, of course, depends on this cookbook being refactored too.

[eherot]

I'm not so keen on the idea of things (like server hostnames for example) being renamed on a piecemeal basis...

[jeffbyrnes]

@eherot server hostnames? How do you mean? All of the hostnames are *-mesos-agent-* now, and have been since I replaced them after MesosCon.

[eherot]

Exactly, resulting in potentially confusing situations like this:

$ knife node show -r prod-mesos-agent-1b-3
prod-mesos-agent-1b-3:
           ^^^^^
  run_list:
    recipe[et_base]
    recipe[et_mesos_slave]
                    ^^^^^

[jeffbyrnes]

@eherot ah, I see what you mean. I had the opportunity, and I took it. Renaming nodes in flight is a pain.

[jeffbyrnes]

@eherot so I think we can merge this in, cut v4.0.0, and move on with life. I don’t foresee this actually breaking anything, since you were quite thorough in your replacement of the offending noun.

[eherot]

This looks ok to merge but I'd love to see the Spec tests work first if at all possible.

[eherot]

;-)

[jeffbyrnes]

Those spec tests aren’t gonna come around; broken on master, in fact. That said, the integration tests should work! I’m tweaking those now.

[jeffbyrnes]

Here’s Mesos’ own epic for this

[jeffbyrnes]

@haizhou You can go ahead & close this as stale 🙂