Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHORE(NPM) - bump @leafygreen-ui/checkbox from 12.0.5 to 13.0.0 #30

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Bumps @leafygreen-ui/checkbox from 12.0.5 to 13.0.0.

Release notes

Sourced from @​leafygreen-ui/checkbox's releases.

@​leafygreen-ui/checkbox@​13.0.0

Major Changes

  • 7a0ff1be: LG-4126

    Disabled Checkbox, RadioBox, and Radio components no longer render the disabled attribute, but rely on aria-disabled instead.

    This change is made to ensure that disabled components are still focusable to users using keyboard navigation.

    For more on aria-disabled see the documentation on MDN

    Additionally, styling changes are made to ensure consistent implementation of disabled state styles.

    Migration guide

    Functionally, migration should be seamless, however there may be unit/integration/e2e tests that relied on this behavior.

    Jest/RTL

    Generally, only this repo should need to test that these components have a specific attribute. We recommend updating unit tests to check that some event was or was not called.

    However, there are cases where this may still need to be tested. In these cases, replace any expect(checkbox).toBeDisabled() with an explicit check for expect(checkbox).toHaveAttribute("aria-disabled", "true").

    Cypress

    Similar to unit tests, you should generally test functionality and not implementation details. However, to test this in Cypress replace any cy.get(checkbox).should('be.disabled'); checks with cy.get(checkbox).invoke('attr', 'aria-disabled').should('eq', 'true');

Patch Changes

  • 15185af0: Imports Storybook utilities from @lg-tools/storybook-utils (previously imported from @leafygreen-ui/lib)
  • 356a53fd: Update TS builds to use [email protected]
  • Updated dependencies [7a0ff1be]
  • Updated dependencies [15185af0]
  • Updated dependencies [356a53fd]
  • Updated dependencies [66df9ab8]
    • @​leafygreen-ui/typography@​18.3.0
    • @​leafygreen-ui/leafygreen-provider@​3.1.12
    • @​leafygreen-ui/lib@​13.3.0
    • @​leafygreen-ui/a11y@​1.4.13
    • @​leafygreen-ui/emotion@​4.0.8
    • @​leafygreen-ui/hooks@​8.1.3
    • @​leafygreen-ui/palette@​4.0.9
    • @​leafygreen-ui/tokens@​2.5.2
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@leafygreen-ui/checkbox](https://github.com/mongodb/leafygreen-ui) from 12.0.5 to 13.0.0.
- [Release notes](https://github.com/mongodb/leafygreen-ui/releases)
- [Commits](https://github.com/mongodb/leafygreen-ui/compare/@leafygreen-ui/[email protected]...@leafygreen-ui/[email protected])

---
updated-dependencies:
- dependency-name: "@leafygreen-ui/checkbox"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 1, 2024
@dependabot dependabot bot requested a review from a team April 1, 2024 17:19
@SupaJoon SupaJoon requested review from SupaJoon and removed request for a team April 3, 2024 13:45
@SupaJoon SupaJoon merged commit 5eaae4d into main Apr 12, 2024
5 checks passed
@SupaJoon SupaJoon deleted the dependabot/npm_and_yarn/leafygreen-ui/checkbox-13.0.0 branch April 12, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant