DEVPROD-5949: Render Resmoke 'All' Logs when given taskID, execution …

…and groupID (#40)
evergreen-ci · Apr 11, 2024 · 80b1169 · 80b1169
1 parent 5331fe3
commit 80b1169
Show file tree

Hide file tree

Showing 22 changed files with 316 additions and 177 deletions.
diff --git a/apps/parsley/config/jest/setupTests.ts b/apps/parsley/config/jest/setupTests.ts
@@ -4,6 +4,7 @@ import "@testing-library/jest-dom/extend-expect";
 // The following two variables are dummy values used in auth.test.tsx.
 process.env.REACT_APP_EVERGREEN_URL = "test-evergreen.com";
 process.env.REACT_APP_GRAPHQL_URL = "test-graphql.com";
+process.env.REACT_APP_SPRUCE_URL = "test-spruce.com";
 
 if (process.env.CI) {
   // Avoid printing debug statements when running tests.

diff --git a/apps/parsley/cypress/integration/resmokeLogs/resmoke_evg_all_logView.ts b/apps/parsley/cypress/integration/resmokeLogs/resmoke_evg_all_logView.ts
@@ -0,0 +1,35 @@
+describe("Basic resmoke log view", () => {
+  const logLink =
+    "/resmoke/mongodb_mongo_master_enterprise_amazon_linux2_arm64_all_feature_flags_jsCore_patch_9801cf147ed208ce4c0ff8dff4a97cdb216f4c22_65f06bd09ccd4eaaccca1391_24_03_12_14_51_29/0/job0/all";
+  beforeEach(() => {
+    cy.visit(logLink);
+  });
+
+  it("should render resmoke lines", () => {
+    cy.dataCy("resmoke-row").should("be.visible");
+    cy.dataCy("ansii-row").should("not.exist");
+  });
+
+  it("the HTML log button is disabled", () => {
+    cy.toggleDetailsPanel(true);
+    cy.dataCy("html-log-button").should("have.attr", "aria-disabled", "true");
+  });
+
+  it("the job logs button has a link to the job logs page", () => {
+    cy.toggleDetailsPanel(true);
+    cy.dataCy("job-logs-button").should(
+      "have.attr",
+      "href",
+      "http://localhost:3000/job-logs/mongodb_mongo_master_enterprise_amazon_linux2_arm64_all_feature_flags_jsCore_patch_9801cf147ed208ce4c0ff8dff4a97cdb216f4c22_65f06bd09ccd4eaaccca1391_24_03_12_14_51_29/0/job0",
+    );
+  });
+
+  it("should show the project, patch, task, and group the breadcrumb", () => {
+    cy.dataCy("project-breadcrumb")
+      .contains("mongodb-mongo-master")
+      .should("be.visible");
+    cy.dataCy("version-breadcrumb").contains("Patch 1994").should("be.visible");
+    cy.dataCy("task-breadcrumb").contains("jsCore").should("be.visible");
+    cy.dataCy("group-breadcrumb").contains("job0").should("be.visible");
+  });
+});
diff --git a/...rsley/src/components/DetailsMenu/DetailsMenuCard/CLIInstructions/CliInstructions.test.tsx b/...rsley/src/components/DetailsMenu/DetailsMenuCard/CLIInstructions/CliInstructions.test.tsx
@@ -87,7 +87,7 @@ describe("cliInstructions", () => {
       hook.current.setLogMetadata({
         buildID: "buildId",
         execution: "0",
-        logType: LogTypes.RESMOKE_LOGS,
+        logType: LogTypes.LOGKEEPER_LOGS,
         taskID: "taskId",
         testID: "testId",
       });

diff --git a/apps/parsley/src/components/DetailsMenu/DetailsMenuCard/CLIInstructions/index.tsx b/apps/parsley/src/components/DetailsMenu/DetailsMenuCard/CLIInstructions/index.tsx
@@ -29,7 +29,7 @@ const getCLICommand = (logMetadata: LogMetadata) => {
         return "";
       }
       return `evergreen buildlogger fetch --task_id ${taskID} --execution ${execution} --test_name ${testID}`;
-    case LogTypes.RESMOKE_LOGS:
+    case LogTypes.LOGKEEPER_LOGS:
       if (!buildID) {
         return "";
       }

diff --git a/...ailsMenu/DetailsMenuCard/Toggles/JumpToFailingLineToggle/JumpToFailingLineToggle.test.tsx b/...ailsMenu/DetailsMenuCard/Toggles/JumpToFailingLineToggle/JumpToFailingLineToggle.test.tsx
@@ -42,7 +42,7 @@ describe("jump to failing line toggle", () => {
     );
     render(<Component />, { wrapper });
     act(() => {
-      hook.current.setLogMetadata({ logType: LogTypes.RESMOKE_LOGS });
+      hook.current.setLogMetadata({ logType: LogTypes.LOGKEEPER_LOGS });
     });
     const jumpToFailingLineToggle = screen.getByDataCy(
       "jump-to-failing-line-toggle",

diff --git a/apps/parsley/src/components/LogRow/CollapsedRow/CollapsedRow.stories.tsx b/apps/parsley/src/components/LogRow/CollapsedRow/CollapsedRow.stories.tsx
@@ -101,7 +101,7 @@ const CollapsedResmokeRowStory = (
   const { setWrap } = preferences;
 
   useEffect(() => {
-    setLogMetadata({ logType: LogTypes.RESMOKE_LOGS });
+    setLogMetadata({ logType: LogTypes.LOGKEEPER_LOGS });
     ingestLines(resmokeLogLines, LogRenderingTypes.Resmoke);
   }, []); // eslint-disable-line react-hooks/exhaustive-deps
 

diff --git a/apps/parsley/src/components/SubHeader/EvergreenTaskSubHeader.test.tsx b/apps/parsley/src/components/SubHeader/EvergreenTaskSubHeader.test.tsx
@@ -36,7 +36,7 @@ describe("evergreen task subheader", () => {
         <EvergreenTaskSubHeader
           buildID="7e208050e166b1a9025c817b67eee48d"
           execution={0}
-          logType={LogTypes.RESMOKE_LOGS}
+          logType={LogTypes.LOGKEEPER_LOGS}
           taskID="mongodb_mongo_master_rhel80_debug_v4ubsan_all_feature_flags_experimental_concurrency_sharded_with_stepdowns_and_balancer_4_linux_enterprise_361789ed8a613a2dc0335a821ead0ab6205fbdaa_22_09_21_02_53_24"
           testID="1716e11b4f8a4541c5e2faf70affbfab"
         />

diff --git a/apps/parsley/src/components/SubHeader/EvergreenTaskSubHeader.tsx b/apps/parsley/src/components/SubHeader/EvergreenTaskSubHeader.tsx
@@ -18,16 +18,18 @@ import { shortenGithash, trimStringFromMiddle } from "utils/string";
 interface Props {
   buildID: string;
   execution: number;
+  fileName?: string;
+  groupID?: string;
   logType?: LogTypes;
   taskID: string;
   testID?: string;
-  fileName?: string;
 }
 
 export const EvergreenTaskSubHeader: React.FC<Props> = ({
   buildID,
   execution,
   fileName,
+  groupID,
   logType,
   taskID,
   testID,
@@ -76,7 +78,7 @@ export const EvergreenTaskSubHeader: React.FC<Props> = ({
 
   let currentTest: { testFile: string; status: string } | null = null;
   switch (logType) {
-    case LogTypes.RESMOKE_LOGS:
+    case LogTypes.LOGKEEPER_LOGS:
       currentTest =
         taskData?.tests?.testResults?.find((test) =>
           test?.logs?.urlRaw?.match(new RegExp(`${testID}`)),
@@ -142,6 +144,14 @@ export const EvergreenTaskSubHeader: React.FC<Props> = ({
           },
         ]
       : []),
+    ...(groupID
+      ? [
+          {
+            "data-cy": "group-breadcrumb",
+            text: groupID,
+          },
+        ]
+      : []),
   ];
 
   return (

diff --git a/apps/parsley/src/components/SubHeader/index.tsx b/apps/parsley/src/components/SubHeader/index.tsx
@@ -11,7 +11,7 @@ const { gray } = palette;
 interface SubHeaderProps {}
 const SubHeader: React.FC<SubHeaderProps> = () => {
   const { isUploadedLog, logMetadata } = useLogContext();
-  const { buildID, execution, fileName, logType, taskID, testID } =
+  const { buildID, execution, fileName, groupID, logType, taskID, testID } =
     logMetadata || {};
 
   return (
@@ -39,6 +39,7 @@ const SubHeader: React.FC<SubHeaderProps> = () => {
               buildID={buildID as string}
               execution={Number(execution)}
               fileName={fileName}
+              groupID={groupID}
               logType={logType}
               taskID={taskID}
               testID={testID as string}

diff --git a/apps/parsley/src/constants/enums.ts b/apps/parsley/src/constants/enums.ts
@@ -2,7 +2,8 @@ enum LogTypes {
   EVERGREEN_TASK_FILE = "EVERGREEN_TASK_FILE",
   EVERGREEN_TASK_LOGS = "EVERGREEN_TASK_LOGS",
   EVERGREEN_TEST_LOGS = "EVERGREEN_TEST_LOGS",
-  RESMOKE_LOGS = "RESMOKE_LOGS",
+  EVERGREEN_COMPLETE_LOGS = "EVERGREEN_COMPLETE_LOGS",
+  LOGKEEPER_LOGS = "LOGKEEPER_LOGS",
   LOCAL_UPLOAD = "LOCAL_UPLOAD",
 }
 

diff --git a/apps/parsley/src/constants/externalURLTemplates.ts b/apps/parsley/src/constants/externalURLTemplates.ts
@@ -14,9 +14,21 @@ const getEvergreenTaskURL = (taskID: string, execution: string | number) => {
   )}`;
 };
 
-const getJobLogsURL = (buildID: string) => `${spruceURL}/job-logs/${buildID}`;
+const getLogkeeperJobLogsURL = (buildID: string) =>
+  `${spruceURL}/job-logs/${buildID}`;
+
+const getEvergreenJobLogsURL = (
+  taskID: string,
+  execution: string | number,
+  groupID: string,
+) => `${spruceURL}/job-logs/${taskID}/${execution}/${groupID}`;
 
 const getLegacyJobLogsURL = (buildID: string) =>
   `${logkeeperURL}/build/${buildID}`;
 
-export { getEvergreenTaskURL, getJobLogsURL, getLegacyJobLogsURL };
+export {
+  getEvergreenTaskURL,
+  getLogkeeperJobLogsURL,
+  getLegacyJobLogsURL,
+  getEvergreenJobLogsURL,
+};
diff --git a/apps/parsley/src/constants/logURLTemplates.ts b/apps/parsley/src/constants/logURLTemplates.ts
@@ -127,8 +127,23 @@ const getEvergreenTaskFileURL = (
   fileName: string,
 ) => `${evergreenURL}/task_file_raw/${taskID}/${execution}/${fileName}`;
 
+/**
+ * getEvergreenCompleteLogsURL constructs an Evergreen URL to download complete logs for a task.
+ * @param taskID - the task ID
+ * @param execution - the execution number of the task
+ * @param groupID - the group ID of the task
+ * @returns an Evergreen URL of the format /rest/v2/tasks/${taskID}/build/TestLogs/${groupID}?execution=${execution}
+ */
+const getEvergreenCompleteLogsURL = (
+  taskID: string,
+  execution: string | number,
+  groupID: string,
+) =>
+  `${evergreenURL}/rest/v2/tasks/${taskID}/build/TestLogs/${groupID}?execution=${execution}`;
+
 export {
   constructEvergreenTaskLogURL,
+  getEvergreenCompleteLogsURL,
   getEvergreenTaskFileURL,
   getEvergreenTaskLogURL,
   getEvergreenTestLogURL,

diff --git a/apps/parsley/src/constants/routes.ts b/apps/parsley/src/constants/routes.ts
@@ -19,10 +19,11 @@ enum slugs {
 }
 
 const routes = {
+  completeLogs: `${paths.resmokeLogs}/:${slugs.taskID}/:${slugs.execution}/:${slugs.groupID}/all`,
   evergreenLogs: `${paths.evergreenLogs}/:${slugs.taskID}/:${slugs.execution}/:${slugs.origin}`,
   login: paths.login,
-  resmokeLogs: `${paths.resmokeLogs}/:${slugs.buildID}/test/:${slugs.testID}`,
-  resmokeLogsAll: `${paths.resmokeLogs}/:${slugs.buildID}/all`,
+  logkeeperLogs: `${paths.resmokeLogs}/:${slugs.buildID}/test/:${slugs.testID}`,
+  logkeeperLogsAll: `${paths.resmokeLogs}/:${slugs.buildID}/all`,
   root: paths.home,
   taskFiles: `${paths.taskFile}/:${slugs.taskID}/:${slugs.execution}/:${slugs.fileName}`,
   testLogs: `${paths.testLogs}/:${slugs.taskID}/:${slugs.execution}/:${slugs.testID}`,

diff --git a/apps/parsley/src/context/LogContext/types.ts b/apps/parsley/src/context/LogContext/types.ts
@@ -17,6 +17,7 @@ interface LogMetadata {
   buildID?: string;
   execution?: string;
   fileName?: string;
+  groupID?: string;
   htmlLogURL?: string;
   jobLogsURL?: string;
   legacyJobLogsURL?: string;

diff --git a/apps/parsley/src/hooks/useLogDownloader/useLogDownloader.test.ts b/apps/parsley/src/hooks/useLogDownloader/useLogDownloader.test.ts
@@ -36,7 +36,7 @@ describe("useLogDownloader", () => {
     // RenderFakeToastContext is a mock of the ToastContext
     RenderFakeToastContext();
     const { result } = renderHook(() =>
-      useLogDownloader({ logType: LogTypes.RESMOKE_LOGS, url: API_URL }),
+      useLogDownloader({ logType: LogTypes.LOGKEEPER_LOGS, url: API_URL }),
     );
     expect(result.current.isLoading).toBe(true);
     await waitFor(() => {
@@ -77,7 +77,7 @@ describe("useLogDownloader", () => {
     // RenderFakeToastContext is a mock of the ToastContext
     RenderFakeToastContext();
     const { result } = renderHook(() =>
-      useLogDownloader({ logType: LogTypes.RESMOKE_LOGS, url: API_URL }),
+      useLogDownloader({ logType: LogTypes.LOGKEEPER_LOGS, url: API_URL }),
     );
     expect(result.current.isLoading).toBe(true);
     expect(result.current.fileSize).toBe(0);
@@ -98,7 +98,7 @@ describe("useLogDownloader", () => {
     // RenderFakeToastContext is a mock of the ToastContext
     RenderFakeToastContext();
     const { result } = renderHook(() =>
-      useLogDownloader({ logType: LogTypes.RESMOKE_LOGS, url: API_URL }),
+      useLogDownloader({ logType: LogTypes.LOGKEEPER_LOGS, url: API_URL }),
     );
     expect(result.current.isLoading).toBe(true);
     await waitFor(() => {
@@ -121,7 +121,7 @@ describe("useLogDownloader", () => {
     const { result } = renderHook(() =>
       useLogDownloader({
         downloadSizeLimit: 5,
-        logType: LogTypes.RESMOKE_LOGS,
+        logType: LogTypes.LOGKEEPER_LOGS,
         url: API_URL,
       }),
     );
@@ -150,7 +150,7 @@ describe("useLogDownloader", () => {
     // RenderFakeToastContext is a mock of the ToastContext
     const { dispatchToast } = RenderFakeToastContext();
     const { result } = renderHook(() =>
-      useLogDownloader({ logType: LogTypes.RESMOKE_LOGS, url: API_URL }),
+      useLogDownloader({ logType: LogTypes.LOGKEEPER_LOGS, url: API_URL }),
     );
     expect(result.current.isLoading).toBe(true);
     await waitFor(() => {

diff --git a/apps/parsley/src/hooks/useTaskQuery/index.ts b/apps/parsley/src/hooks/useTaskQuery/index.ts
@@ -37,20 +37,20 @@ export const useTaskQuery = ({
   logType,
   taskID,
 }: UseTaskQueryProps): UseTaskQueryReturnType => {
-  const isResmoke = logType === LogTypes.RESMOKE_LOGS;
+  const isLogkeeper = logType === LogTypes.LOGKEEPER_LOGS;
   const { data: taskData, loading: taskLoading } = useQuery<
     TaskQuery,
     TaskQueryVariables
   >(GET_TASK, {
-    skip: isResmoke || !taskID,
+    skip: isLogkeeper || !taskID,
     variables: { execution: Number(execution), taskId: String(taskID) },
   });
 
   const { data: logkeeperData, loading: logkeeperLoading } = useQuery<
     LogkeeperTaskQuery,
     LogkeeperTaskQueryVariables
   >(GET_LOGKEEPER_TASK, {
-    skip: logType !== LogTypes.RESMOKE_LOGS || !buildID,
+    skip: !isLogkeeper || !buildID,
     variables: { buildId: String(buildID) },
   });
 

diff --git a/apps/parsley/src/hooks/useTaskQuery/useTaskQuery.test.tsx b/apps/parsley/src/hooks/useTaskQuery/useTaskQuery.test.tsx
@@ -41,7 +41,7 @@ describe("useTaskQuery", () => {
       () =>
         useTaskQuery({
           buildID: "7e208050e166b1a9025c817b67eee48d",
-          logType: LogTypes.RESMOKE_LOGS,
+          logType: LogTypes.LOGKEEPER_LOGS,
         }),
       {
         wrapper,

diff --git a/apps/parsley/src/pages/LogDrop/ParseLogSelect/ParseLogSelect.test.tsx b/apps/parsley/src/pages/LogDrop/ParseLogSelect/ParseLogSelect.test.tsx
@@ -51,7 +51,7 @@ describe("parse log select", () => {
 
   it("clicking the 'Process Log' button calls the onParse function", async () => {
     const user = userEvent.setup();
-    mockedGet.mockImplementation(() => LogTypes.RESMOKE_LOGS);
+    mockedGet.mockImplementation(() => LogTypes.LOGKEEPER_LOGS);
     const onParse = jest.fn();
     render(
       <ParseLogSelect

diff --git a/apps/parsley/src/pages/LogView/LoadingPage/index.tsx b/apps/parsley/src/pages/LogView/LoadingPage/index.tsx
@@ -56,7 +56,7 @@ const LoadingPage: React.FC<LoadingPageProps> = ({ logType }) => {
     useFetch<LogkeeperMetadata>(
       getResmokeLogURL(buildID || "", { metadata: true, testID }),
       {
-        skip: buildID === undefined,
+        skip: logType !== LogTypes.LOGKEEPER_LOGS || buildID === undefined,
       },
     );
 
@@ -77,6 +77,7 @@ const LoadingPage: React.FC<LoadingPageProps> = ({ logType }) => {
         buildID,
         execution: execution || String(logkeeperMetadata?.execution || 0),
         fileName,
+        groupID,
         htmlLogURL,
         jobLogsURL,
         legacyJobLogsURL,
@@ -99,6 +100,7 @@ const LoadingPage: React.FC<LoadingPageProps> = ({ logType }) => {
     error,
     execution,
     fileName,
+    groupID,
     htmlLogURL,
     ingestLines,
     isLoadingLogkeeperMetadata,