This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-1976: Migrate downstream tasks table to LeafyGreen table #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophstad
reviewed
Mar 22, 2024
There was a problem hiding this comment.
[nit] Preference have the filename match the component name DownstreamTasksTable
Comment on lines
63
to
69
| if (id === TaskSortCategory.Status) { | ||
| dispatch({ type: "setStatuses", statuses: value as string[] }); | ||
| } | ||
| if (id === TaskSortCategory.BaseStatus) { | ||
| dispatch({ type: "setBaseStatuses", baseStatuses: value as string[] }); | ||
| } | ||
| if (id === TaskSortCategory.Variant) { |
There was a problem hiding this comment.
[nit] Should these use else if to avoid checking each statement on every loop? Or switch case
sophstad
approved these changes
Mar 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-1976
Description
Updates the downstream tasks table to use LeafyGreen table. The state of this table is managed by a reducer, and should not appear in the URL.
Screenshots
Testing