Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

DEVPROD-5336 Allow projects to be deleted for projects not attached to a repo #2288

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

ZackarySantana
Copy link
Contributor

@ZackarySantana ZackarySantana commented Mar 5, 2024

DEVPROD-5336

Description

This changes the conditional to include projects & projects attached to repos. The only type of projectref non-deletable (which is just hiding) is the repo project.

Screenshots

With the UI change, the button showed up correctly. The true test was testing it against the PR (linked below) that changes the route to allow for this behavior.

The following is using this change always (I tested without but it just doesn't show the button). The 'change' referenced below is the app PR/route change.

Before change:
DeleteProject1

After change:
DeleteProject2

Testing

There's this PR in the app repository that I deployed and tested against. Separately I tested the app PR directly against the endpoint rather than spruce.

Here's the project I deleted: https://spruce-staging.corp.mongodb.com/project/deletemepls/settings/general

Evergreen PR

evergreen-ci/evergreen#7591

@ZackarySantana ZackarySantana requested a review from a team March 5, 2024 15:07
@ZackarySantana ZackarySantana self-assigned this Mar 5, 2024
Copy link

cypress bot commented Mar 5, 2024

3 flaky tests on run #16054 ↗︎

0 547 10 0 Flakiness 3

Details:

fix: delete project show up for og projects
Project: Spruce Commit: 491ee17524
Status: Passed Duration: 18:37 💡
Started: Mar 5, 2024 3:14 PM Ended: Mar 5, 2024 3:32 PM
Flakiness  cypress/integration/distroSettings/host_section.ts • 3 flaky tests

View Output Video

Test Artifacts
host section > using legacy ssh > shows an error when selecting an incompatible host communication method Screenshots Video
host section > using User Data bootstrap method > hides resource limit fields when the architecture is not Linux Screenshots Video
host section > using User Data bootstrap method > saves bootstrap settings Screenshots Video

Review all test suite changes for PR #2288 ↗︎

@ZackarySantana ZackarySantana changed the title DEVPROD-965 Allow projects to be deleted for projects not attached to a repo DEVPROD-5336 Allow projects to be deleted for projects not attached to a repo Mar 5, 2024
@ZackarySantana ZackarySantana merged commit 4a2bcf7 into evergreen-ci:main Mar 8, 2024
5 of 6 checks passed
@ZackarySantana ZackarySantana deleted the DEVPROD-965 branch March 8, 2024 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants