This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-5336 Allow projects to be deleted for projects not attached to a repo #2288
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-5336
Description
This changes the conditional to include projects & projects attached to repos. The only type of projectref non-deletable (which is just hiding) is the repo project.
Screenshots
With the UI change, the button showed up correctly. The true test was testing it against the PR (linked below) that changes the route to allow for this behavior.
The following is using this change always (I tested without but it just doesn't show the button). The 'change' referenced below is the app PR/route change.
Before change:
After change:
Testing
There's this PR in the app repository that I deployed and tested against. Separately I tested the app PR directly against the endpoint rather than spruce.
Here's the project I deleted: https://spruce-staging.corp.mongodb.com/project/deletemepls/settings/general
Evergreen PR
evergreen-ci/evergreen#7591