Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

DEVPROD-5132: Make tags unique #2282

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

sophstad
Copy link
Contributor

@sophstad sophstad commented Mar 1, 2024

DEVPROD-5132

Description

  • Ahead of the monorepo merge, make Spruce's tags unique by using spruce/vX.Y.Z. The commit message has also been changed from "vX.Y.Z" to "spruce/vX.Y.Z"
  • Remove references to remote URL. We can assume users have their upstream properly configured (and if they don't commands will fail, which is fine)
  • Added a new git tag regex to Spruce's project settings. When this is merged I will delete the old one:
    image

Testing

  • Tested with my wifi off 🤣 the correct tag names were generated and git attempted to push to the correct place as part of the postversion script!

Copy link

cypress bot commented Mar 1, 2024

1 flaky test on run #15993 ↗︎

0 547 10 0 Flakiness 1

Details:

Merge branch 'main' of https://github.com/evergreen-ci/spruce into DEVPROD-5132
Project: Spruce Commit: 2efd5c78f4
Status: Passed Duration: 19:44 💡
Started: Mar 1, 2024 4:19 PM Ended: Mar 1, 2024 4:39 PM
Flakiness  cypress/integration/distroSettings/host_section.ts • 1 flaky test

View Output Video

Test Artifacts
host section > using User Data bootstrap method > saves bootstrap settings Screenshots Video

Review all test suite changes for PR #2282 ↗︎

@sophstad sophstad requested a review from a team March 1, 2024 16:16
@sophstad sophstad marked this pull request as ready for review March 1, 2024 16:16
Copy link
Contributor

@minnakt minnakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with my wifi off too 🫣

@@ -0,0 +1,2 @@
version-tag-prefix spruce/v
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(comment placement is random) I think you'll want to use the Variant Regex + Task Regex combination instead of the Variant Tags + Task Tags combination! I don't think we use tags in our yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great catch! I made this update in Spruce project settings.

@sophstad sophstad merged commit 202cb82 into evergreen-ci:main Mar 4, 2024
5 of 6 checks passed
@sophstad sophstad deleted the DEVPROD-5132 branch March 4, 2024 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants