This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-3362 Mark Evergreen ide as deprecated #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 flaky tests on run #16036 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| host section > using legacy ssh > shows an error when selecting an incompatible host communication method |
Screenshots
Video
|
|
Review all test suite changes for PR #2276 ↗︎
sophstad
reviewed
Feb 27, 2024
package.json
Outdated
| @@ -72,6 +72,7 @@ | |||
| "@leafygreen-ui/guide-cue": "5.0.5", | |||
| "@leafygreen-ui/icon": "11.26.0", | |||
| "@leafygreen-ui/icon-button": "15.0.19", | |||
| "@leafygreen-ui/info-sprinkle": "^1.0.2", | |||
There was a problem hiding this comment.
Should this dep be pinned?
There was a problem hiding this comment.
Personally would prefer not to add another nesting level here and just have src/pages/spawn/spawnHost/SpawnHostCard.tsx and src/pages/spawn/spawnHost/constants.ts. Your call though!
There was a problem hiding this comment.
I was trying to colocate all of the related files into the same folder but since we're not really consistent about this I undid it.
sophstad
approved these changes
Mar 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-3362
Description
Marks the Evergreen IDE as deprecated for Ubuntu 1804 workstations and also hides the link for other workstations that don't have the ide installed.
Screenshots