Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

DEVPROD-835: Add "Depends On" tooltip #2256

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Conversation

sophstad
Copy link
Contributor

@sophstad sophstad commented Feb 12, 2024

DEVPROD-835

Description

For tasks in the task table that are blocked, show blocking tasks in a tooltip when the badge is hovered over

Screenshots

image

Testing

  • Add Cypress test

Copy link

cypress bot commented Feb 12, 2024

1 flaky test on run #15875 ↗︎

0 547 10 0 Flakiness 1
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

PR comments
Project: Spruce Commit: 1c932a645a
Status: Passed Duration: 19:19 💡
Started: Feb 23, 2024 5:47 PM Ended: Feb 23, 2024 6:06 PM

Review all test suite changes for PR #2256 ↗︎

@sophstad sophstad marked this pull request as ready for review February 13, 2024 15:33
@sophstad sophstad requested a review from a team February 13, 2024 15:33
<TaskStatusBadge status={status} id={id} execution={execution} />
render: (status: string, { dependsOn, execution, id }) =>
dependsOn?.length && status === TaskStatus.Blocked ? (
<Tooltip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may have to tweak the z-index (the table icons overlap it)!:

Screenshot 2024-02-14 at 10 27 23 AM

</span>
}
>
Depends on <>{pluralize("task", dependsOn.length)}</>:{" "}
Copy link
Contributor

@minnakt minnakt Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the fragment necessary? :0

Suggested change
Depends on <>{pluralize("task", dependsOn.length)}</>:{" "}
Depends on {pluralize("task", dependsOn.length)}:{" "}

Copy link
Contributor

@khelif96 khelif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

How do you feel about updating the design a bit so that it shows the tasks that are actually being depended on and their statuses?

@sophstad
Copy link
Contributor Author

image How do you feel about updating the design a bit so that it shows the tasks that are actually being depended on and their statuses?

Are you referring to displaying metStatus? The actual status of the depended on task isn't queryable at the moment. (schema)

@khelif96
Copy link
Contributor

image How do you feel about updating the design a bit so that it shows the tasks that are actually being depended on and their statuses?

Are you referring to displaying metStatus? The actual status of the depended on task isn't queryable at the moment. (schema)

Yes MetStatus since that indicates which dependency has not met the expected status.

@sophstad sophstad merged commit 1f73e92 into evergreen-ci:main Feb 23, 2024
5 of 6 checks passed
@sophstad sophstad deleted the DEVPROD-835 branch February 23, 2024 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants