-
Notifications
You must be signed in to change notification settings - Fork 25
DEVPROD-835: Add "Depends On" tooltip #2256
Conversation
1 flaky test on run #15875 ↗︎
Details:
Review all test suite changes for PR #2256 ↗︎ |
<TaskStatusBadge status={status} id={id} execution={execution} /> | ||
render: (status: string, { dependsOn, execution, id }) => | ||
dependsOn?.length && status === TaskStatus.Blocked ? ( | ||
<Tooltip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/components/TasksTable/index.tsx
Outdated
</span> | ||
} | ||
> | ||
Depends on <>{pluralize("task", dependsOn.length)}</>:{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the fragment necessary? :0
Depends on <>{pluralize("task", dependsOn.length)}</>:{" "} | |
Depends on {pluralize("task", dependsOn.length)}:{" "} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about updating the design a bit so that it shows the tasks that are actually being depended on and their statuses? Are you referring to displaying |
How do you feel about updating the design a bit so that it shows the tasks that are actually being depended on and their statuses? Yes MetStatus since that indicates which dependency has not met the expected status. |
DEVPROD-835
Description
For tasks in the task table that are blocked, show blocking tasks in a tooltip when the badge is hovered over
Screenshots
Testing