Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

DEVPROD-4166 Add breaking commits option in previous commits dropdown #2254

Merged
merged 24 commits into from
Feb 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
0e412ab
build: add to gql query
ZackarySantana Feb 9, 2024
1dfaa64
feat: add breaking commit in to selector
ZackarySantana Feb 9, 2024
e66d46e
fix: add last passing task condition
ZackarySantana Feb 9, 2024
347ca0d
refactor: rename previous commits to relevant commits
ZackarySantana Feb 9, 2024
86d2080
fix: revert update
ZackarySantana Feb 13, 2024
4fa8c5d
refactor: baseStatus -> status
ZackarySantana Feb 20, 2024
c1d95e0
doc: last breaking task query
ZackarySantana Feb 20, 2024
190bbe9
fix: use task order rather than version
ZackarySantana Feb 20, 2024
7435611
fix: tests
ZackarySantana Feb 20, 2024
81abcc0
feat: add some tests
ZackarySantana Feb 21, 2024
7018fcb
fix: switch status check to be not failed
ZackarySantana Feb 23, 2024
a546058
refactor: add permalink to comment
ZackarySantana Feb 27, 2024
b4ee498
refactor: capitalize relevant commits
ZackarySantana Feb 27, 2024
3edc9bd
fix: github link to backend code
ZackarySantana Feb 27, 2024
e0885c3
refactor: previous commit data tag
ZackarySantana Feb 27, 2024
77d27e5
fix: redo pre commit hook
ZackarySantana Feb 27, 2024
f1865c9
fix: revert precommit
ZackarySantana Feb 27, 2024
a34965f
fix: revert it no history
ZackarySantana Feb 27, 2024
718962d
refactor: rename files
ZackarySantana Feb 27, 2024
42bdc5d
Merge branch 'main' into DEVPROD-4166
ZackarySantana Feb 27, 2024
e4af068
fix: skip order number in test
ZackarySantana Feb 28, 2024
a13877b
fix: test cases
ZackarySantana Feb 28, 2024
ef76d29
fix: test
ZackarySantana Feb 29, 2024
c71b07f
Merge branch 'main' into DEVPROD-4166
ZackarySantana Feb 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: previous commit data tag
ZackarySantana committed Feb 27, 2024
commit e0885c3471564d953acfc8da0f6fac9f12aba3af
2 changes: 1 addition & 1 deletion src/analytics/task/useTaskAnalytics.ts
Original file line number Diff line number Diff line change
@@ -70,7 +70,7 @@ type Action =
| { name: "Click Last Failing Stepback Task Link" }
| { name: "Click Previous Stepback Task Link" }
| { name: "Click Next Stepback Task Link" }
| { name: "Submit Previous Commit Selector"; type: CommitType };
| { name: "Submit Relevant Commit Selector"; type: CommitType };

export const useTaskAnalytics = () => {
const { id } = useParams<{ id: string }>();
8 changes: 4 additions & 4 deletions src/pages/task/actionButtons/RelevantCommits/index.tsx
Original file line number Diff line number Diff line change
@@ -174,7 +174,7 @@ export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
disabled={parentLoading}
onClick={() =>
sendEvent({
name: "Submit Previous Commit Selector",
name: "Submit Relevant Commit Selector",
type: CommitType.Base,
})
}
@@ -187,7 +187,7 @@ export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
disabled={breakingLoading || breakingTask === undefined}
onClick={() =>
sendEvent({
name: "Submit Previous Commit Selector",
name: "Submit Relevant Commit Selector",
type: CommitType.Breaking,
})
}
@@ -200,7 +200,7 @@ export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
disabled={passingLoading}
onClick={() =>
sendEvent({
name: "Submit Previous Commit Selector",
name: "Submit Relevant Commit Selector",
type: CommitType.LastPassing,
})
}
@@ -213,7 +213,7 @@ export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
disabled={executedLoading}
onClick={() =>
sendEvent({
name: "Submit Previous Commit Selector",
name: "Submit Relevant Commit Selector",
type: CommitType.LastExecuted,
})
}
8 changes: 4 additions & 4 deletions src/pages/task/actionButtons/relevantCommits/index.tsx
Original file line number Diff line number Diff line change
@@ -174,7 +174,7 @@ export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
disabled={parentLoading}
onClick={() =>
sendEvent({
name: "Submit Previous Commit Selector",
name: "Submit Relevant Commit Selector",
type: CommitType.Base,
})
}
@@ -187,7 +187,7 @@ export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
disabled={breakingLoading || breakingTask === undefined}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of a UX comment, but when testing this on larger projects (like mongodb), it can take a while for the query to finish. I think it could be good to have some indication that the query is still loading (maybe a loading spinner)?

You could make a separate ticket to explore this, since it wasn't covered by the original designs! Or you can experiment (but only if you want to)!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm that might be a good idea. I think adding a loading indicator to the relevant task button might be useful but from my testing, usually it loads as fast as the main page data. I think it would be nice if we did think of some standard for links/buttons/sections that are in the process of loading but we have sent a query for them.

I thought it could be a less grayed out button, italicized, some small icon next to it, or a loading spinner next to it. I just tried some with like italicized but I'm not confident in how they look so I think I'll leave it up for future discussion

onClick={() =>
sendEvent({
name: "Submit Previous Commit Selector",
name: "Submit Relevant Commit Selector",
type: CommitType.Breaking,
})
}
@@ -200,7 +200,7 @@ export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
disabled={passingLoading}
onClick={() =>
sendEvent({
name: "Submit Previous Commit Selector",
name: "Submit Relevant Commit Selector",
type: CommitType.LastPassing,
})
}
@@ -213,7 +213,7 @@ export const RelevantCommits: React.FC<RelevantCommitsProps> = ({ taskId }) => {
disabled={executedLoading}
onClick={() =>
sendEvent({
name: "Submit Previous Commit Selector",
name: "Submit Relevant Commit Selector",
type: CommitType.LastExecuted,
})
}