DEVPROD-2707: Avoid modifying parent patch when restarting downstream tasks

[minnakt]

DEVPROD-2707

Description

This PR fixes a bug where restarting a downstream task via the VersionRestartModal would also restart all of the tasks in the parent patch.

The issue seems to stems from a change in restart logic made in Evergreen four months ago. When restarting a downstream task from the UI, the payload looks like the following:

{
   // In the parent patch, restart nothing.
   { 
        versionId: "123", 
        taskIds: []
    },
   // In the child patch, restart "downstream-task".
   { 
        versionId: "123", 
        taskIds: ["downstream-task"]
    }
}

However, according to the function that restarts versions, an empty taskIds array means that ALL completed tasks belonging to the version will be restarted. See screenshot below:

The given payload means that "downstream-task" will be correctly restarted in the child patch, but so will every other completed task in the parent patch.

To correct this we can just remove any items from the payload that have an empty taskIds array.

Testing

• Restarted my patch on staging with these changes and confirmed that only my downstream task restarted

[cypress]

1 flaky test on run #15594 ↗︎

0

545

10

0

1

Details:

DEVPROD-2707: Prevent restarting entire patch when restarting downstream tasks
Project: Spruce	Commit: b9df9bb977
Status: Passed	Duration: 20:49 💡
Started: Feb 5, 2024 11:48 PM	Ended: Feb 6, 2024 12:09 AM

  cypress/integration/distroSettings/host_section.ts • 1 flaky test

View Output Video

Test		Artifacts
host section > using legacy ssh > shows an error when selecting an incompatible host communication method		Screenshots Video

Review all test suite changes for PR #2251 ↗︎

[khelif96]

Nice! 🚀