This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-3935 Use correct query for project health view setting #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #15413 ↗︎
Details:
Review all test suite changes for PR #2242 ↗︎ |
||||||||||||||||||||
Co-authored-by: Sophie Stadler <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-3935
Description
We have logged nearly 7k events to sentry due to a failing permission check caused by the
projectHealthViewquery consistently failing. It was trying to use theProjectSettingsquery to fetch theprojectHealthViewstateSince most users don't have project settings access this query always fails and will consistently report an error.
This pr updates it so that we use a query that does not require the same permissions.
Testing
Since I am an admin it is difficult to test but since the query does not have a permissions check directive this should work.