This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-1122 Add stepback information to task metadata #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 flaky tests on run #14780 ↗︎
Details:
Review all test suite changes for PR #2206 ↗︎ |
||||||||||||||||||||
|
I'm not sure what to do about the cypress/flake. I don't think my code caused it |
SupaJoon
approved these changes
Dec 28, 2023
You can ignore it. That check isn't part of the patch result. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-1122
Description
This adds and propogates the "stepbackInfo" field in the Task struct to the task page's metadata card on the left hand side.
Screenshots
I explain in the video:
Resize.video.project.Dec.28.mp4
Testing
Tested via staging. I considered some tests for it but I'm not sure if it is worth testing, since it is only links from the task data. I thought it might be more baggage to test it via cypress than the returns- but if the UI team feels otherwise, I won't hesitate to add them! I don't hold this opinion strongly, it's more so I don't want to add roi tests
Evergreen PR
Evergreen PR