This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-2227: Remove family triggers from trigger definitions #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #15085 ↗︎
Details:
Review all test suite changes for PR #2203 ↗︎ |
||||||||||||||||||||
SupaJoon
approved these changes
Dec 26, 2023
src/constants/triggers.ts
Outdated
| @@ -309,7 +309,7 @@ export const projectTriggers: Trigger = { | |||
| [ProjectTriggers.SUCCESSFUL_TASK_EXCEEDS_DURATION]: { | |||
| trigger: TriggerType.SUCCESSFUL_EXCEEDS_DURATION, | |||
| resourceType: ResourceType.Task, | |||
| label: "The Runtime For a Successful Task Exceeds Some Duration", | |||
| label: "The runtime For a successful task exceeds some duration", | |||
There was a problem hiding this comment.
Suggested change
| label: "The runtime For a successful task exceeds some duration", | |
| label: "The runtime for a successful task exceeds some duration", |
src/constants/triggers.ts
Outdated
| }; | ||
|
|
||
| export const convertFamilyTrigger = (trigger: string) => { | ||
| export const fromFamilyTrigger = (trigger: string) => { |
There was a problem hiding this comment.
Can this function have a comment on why it's used?
Suggested change
| export const fromFamilyTrigger = (trigger: string) => { | |
| export const simplifyFamilyTrigger = (trigger: string) => { |
| @@ -25,9 +25,10 @@ const getTriggerText = (trigger: string, resourceType: string) => { | |||
| }; | |||
|
|
|||
| const getTriggerEnum = (trigger: string, resourceType: string) => { | |||
| const convertedTrigger = fromFamilyTrigger(trigger); | |||
There was a problem hiding this comment.
Can you improve the variable naming for convertedTrigger. The family conversion logic may also do well in the resolver.
There was a problem hiding this comment.
The resolver is a good idea! I will file a ticket for it -- shouldn't be too difficult of a change!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-2227
Description
This PR removes the usage of family triggers from the trigger definitions.
It's too complicated to process which trigger we need to assign in the frontend. The notifications are already quite tricky and they would become even harder to understand if we added another layer of complexity. Instead, we will make up for it by doing some extra processing in the backend.
Evergreen PR