This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-2637 Add Guide Cue for Parsley viewable log files #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #14723 ↗︎
Details:
Review all test suite changes for PR #2193 ↗︎ |
||||||||||||||||||||
SupaJoon
approved these changes
Dec 19, 2023
Comment on lines
22
to
23
| triggerRef: React.RefObject<HTMLAnchorElement>; | ||
| index: number; |
There was a problem hiding this comment.
Suggested change
| triggerRef: React.RefObject<HTMLAnchorElement>; | |
| index: number; | |
| guideCueTriggerRef: React.RefObject<HTMLAnchorElement>; | |
| firstParsleyFileIndex: number; |
Comment on lines
+97
to
+100
| const firstParsleyFileIndex = useMemo( | ||
| () => files.findIndex((file) => file.urlParsley !== null), | ||
| [files] | ||
| ); |
There was a problem hiding this comment.
I think the useMemo is overkill here. The computation result is a number as opposed to a reference. This component only has two props and one of which is cached in Apollo. And there is only 1 truly stateful variable (useState)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-2637
Description
This PR adds a guide cue to point users to the Open in Parsley button for task-uploaded files. The guide cue is only shown on the first visible Parsley button.
There is a scroll effect that accomplishes 2 things.
Screenshots