This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-1661 add disk metrics to honeycomb metrics link #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed test on run #14643 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Public Key Management Page > Edit Key Modal > After submitting, the key name and key value are updated |
Screenshots
Video
|
|
Review all test suite changes for PR #2183 ↗︎
|
evergreen retry |
minnakt
approved these changes
Dec 13, 2023
src/constants/externalResources.ts
Outdated
Comment on lines
127
to
140
| ].concat( | ||
| diskDevices | ||
| .map((device) => [ | ||
| { op: "RATE_AVG", column: `system.disk.io.${device}.read` }, | ||
| { op: "RATE_AVG", column: `system.disk.io.${device}.write` }, | ||
| { op: "RATE_AVG", column: `system.disk.operations.${device}.read` }, | ||
| { | ||
| op: "RATE_AVG", | ||
| column: `system.disk.operations.${device}.write`, | ||
| }, | ||
| { op: "RATE_AVG", column: `system.disk.io_time.${device}` }, | ||
| ]) | ||
| .flat() | ||
| ), |
There was a problem hiding this comment.
Disclaimer that the lint might be wrong so I wouldn't suggest committing this suggestion via the button 😅
Suggested change
| ].concat( | |
| diskDevices | |
| .map((device) => [ | |
| { op: "RATE_AVG", column: `system.disk.io.${device}.read` }, | |
| { op: "RATE_AVG", column: `system.disk.io.${device}.write` }, | |
| { op: "RATE_AVG", column: `system.disk.operations.${device}.read` }, | |
| { | |
| op: "RATE_AVG", | |
| column: `system.disk.operations.${device}.write`, | |
| }, | |
| { op: "RATE_AVG", column: `system.disk.io_time.${device}` }, | |
| ]) | |
| .flat() | |
| ), | |
| ...diskDevices | |
| .flatMap((device) => [ | |
| { op: "RATE_AVG", column: `system.disk.io.${device}.read` }, | |
| { op: "RATE_AVG", column: `system.disk.io.${device}.write` }, | |
| { op: "RATE_AVG", column: `system.disk.operations.${device}.read` }, | |
| { | |
| op: "RATE_AVG", | |
| column: `system.disk.operations.${device}.write`, | |
| }, | |
| { op: "RATE_AVG", column: `system.disk.io_time.${device}` }, | |
| ]) | |
| ], |
Comment on lines
83
to
84
| describe("getTaskSystemMetricsUrlWithDisks", () => { | ||
| it("generates the correct url", () => { |
There was a problem hiding this comment.
I'd recommend just adding this test to the block above, since they test the same function! And renaming the block to getHoneycombSystemMetricsUrl (maybe getTaskSystemMetricsUrl was the old name?)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-1661
Description
This ought to be the last of the PRs for this feature. This modifies the Honeycomb system metrics link to include disk stats for the disk names that were recorded when a task finished running.
Screenshots
N/A
Testing
This query got generated for a task with a distro that had two disk devices configured.
Evergreen PR
evergreen-ci/evergreen#7308