This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-1973: Update public keys table #2174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky test on run #14482 ↗︎
Details:
Review all test suite changes for PR #2174 ↗︎ |
||||||||||||||||||||
minnakt
approved these changes
Nov 29, 2023
| data: { myPublicKeys: [...data.updatePublicKey] }, | ||
| }); | ||
| }, | ||
| refetchQueries: ["MyPublicKeys"], |
Comment on lines
72
to
82
| <Button | ||
| size="small" | ||
| data-cy="edit-btn" | ||
| leftGlyph={<Icon glyph="Edit" />} | ||
| onClick={() => { | ||
| setEditModalProps({ | ||
| initialPublicKey: { key, name }, | ||
| visible: true, | ||
| }); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
Possibly could look nice if we turned these into IconButtons? its just a suggestion :)
There was a problem hiding this comment.
Alas it looked a bit weird :( we use this action button pattern elsewhere too so I think the consistency is good!
| cell: ({ row }) => { | ||
| const { key, name } = row.original; | ||
| return ( | ||
| <ButtonContainer className="w-[100px]"> |
There was a problem hiding this comment.
just double checking that you mean to keep this className here
|
|
||
| return ( | ||
| <BaseTable | ||
| data-cy="hosts-table" |
There was a problem hiding this comment.
data-cy should probably be updated!
| @@ -131,25 +25,16 @@ export const PublicKeysTab: React.FC = () => { | |||
| }); | |||
| }} | |||
| > | |||
| Add New Key | |||
| Add key | |||
| </PlusButton> | |||
| <TableContainer> | |||
There was a problem hiding this comment.
you could possibly remove the TableContainer here, the space between the button and table seems like a lot
|
Merging since the flake failure is also present on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-1973
Description
MyPublicKeysquery insteadScreenshots
Testing
Evergreen PR