Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

DEVPROD-789: Fix spacing bug in ArrayFieldTemplate #2170

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

minnakt
Copy link
Contributor

@minnakt minnakt commented Nov 28, 2023

DEVPROD-789

Description

There was an odd spacing around array buttons because we always rendered the <Placeholder> component for an empty array, even if placeholder was not defined.

Screenshots

(These are just a few examples, you would be able to see it on any array form element.)

Before After
Screenshot 2023-11-28 at 12 12 20 PM Screenshot 2023-11-28 at 12 16 19 PM
Before After
Screenshot 2023-11-28 at 12 14 00 PM Screenshot 2023-11-28 at 12 16 11 PM

Copy link

cypress bot commented Nov 28, 2023

Passing run #14409 ↗︎

0 605 7 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

DEVPROD-789: Fix spacing bug in ArrayFieldTemplate
Project: Spruce Commit: 4b12cda191
Status: Passed Duration: 18:47 💡
Started: Nov 28, 2023 5:35 PM Ended: Nov 28, 2023 5:53 PM

Review all test suite changes for PR #2170 ↗︎

@minnakt minnakt marked this pull request as ready for review November 28, 2023 18:06
@minnakt minnakt requested a review from a team November 28, 2023 18:06
Copy link
Contributor

@sophstad sophstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay 💆‍♀️

@minnakt minnakt merged commit dfda0a8 into evergreen-ci:main Nov 28, 2023
5 checks passed
@minnakt minnakt deleted the DEVPROD-789 branch November 28, 2023 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants