This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-1661 add distro setting for mountpoints #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
evergreen-ci/evergreen#7256 adds the mountpoint to the distro mutation. |
1 flaky test on run #14479 ↗︎
Details:
Review all test suite changes for PR #2157 ↗︎ |
||||||||||||||||||||
SupaJoon
suggested changes
Nov 29, 2023
| @@ -48,6 +49,7 @@ export const gqlToForm = ((data) => { | |||
| isVirtualWorkStation, | |||
| icecreamSchedulerHost: iceCreamSettings.schedulerHost, | |||
| icecreamConfigPath: iceCreamSettings.configPath, | |||
| mountpoints, | |||
There was a problem hiding this comment.
The form isn't allowing save because it wants mountpoints to be an array but instead it is null when the data initially loads.
Suggested change
| mountpoints, | |
| mountpoints: mountpoints ?? [], |
There was a problem hiding this comment.
I found that out by logging here:
|
@SupaJoon it looks like e2e passed 🕺 ! |
SupaJoon
approved these changes
Dec 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-1661
Description
evergreen-ci/evergreen#7213 added a new setting to the legacy distros page for mountpoints in the distro. This PR will add the setting to the new distro page as well.
Screenshots
Testing
I'm not completely clear how to test this. The field is added to the test data/transformers test, but I'm sure there must be other tests I can add it to.
Evergreen PR
evergreen-ci/evergreen#7213