This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-942 Support regular expression search on configure tasks page #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #13714 ↗︎
Details:
Review all test suite changes for PR #2132 ↗︎ |
||||||||||||||||||||
minnakt
approved these changes
Nov 6, 2023
| </IconTooltip> | ||
| ) | ||
| } | ||
| validatorErrorMessage="Invalid Regular Expression" |
There was a problem hiding this comment.
nit:
Suggested change
| validatorErrorMessage="Invalid Regular Expression" | |
| validatorErrorMessage="Invalid regular expression" |
| onChange = () => {}, | ||
| onSubmit = () => {}, | ||
| validator = () => true, | ||
| validatorErrorMessage = "", |
There was a problem hiding this comment.
It might make sense to put a default message here, otherwise it'll just be blank. Or, force it to be a required prop
| * `onSubmit` will be called when the user submits a new input with the enter key or the plus button | ||
| * if the input is valid | ||
| * @param value - the value of the input | ||
| * @returns |
There was a problem hiding this comment.
nit. either delete or add description after returns
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-942
Description
TextInputWithValidatorcomponent since this seems to be a common pattern.TextInputWithValidatoron configure page to support using regular expressions to filter.Screenshots