Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

DEVPROD-1759 upgrade LG guide cue #2131

Closed
wants to merge 1 commit into from
Closed

Conversation

ybrill
Copy link
Contributor

@ybrill ybrill commented Oct 31, 2023

DEVPROD-1759

Description

We discovered that the guide cue was broken in the dev build. The 5.0.0 release should fix it. This PR upgrades to 5.0.4.

Testing

The dev build shows the guide cue now.

@ybrill ybrill requested a review from khelif96 October 31, 2023 21:12
@ybrill ybrill changed the title upgrade LG guide cue DEVPROD-1759 upgrade LG guide cue Oct 31, 2023
Copy link
Contributor

@khelif96 khelif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass

Copy link

cypress bot commented Oct 31, 2023

Passing run #13547 ↗︎

0 601 7 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

upgrade LG guide cue
Project: Spruce Commit: 7fe698b778
Status: Passed Duration: 18:49 💡
Started: Oct 31, 2023 10:05 PM Ended: Oct 31, 2023 10:24 PM

Review all test suite changes for PR #2131 ↗︎

@ybrill
Copy link
Contributor Author

ybrill commented Oct 31, 2023

@khelif96 can it be assumed that the failing test is unrelated?

@minnakt
Copy link
Contributor

minnakt commented Oct 31, 2023

can it be assumed that the failing test is unrelated?

@ybrill It is unrelated, don't worry about it =)

And just wanted to flag that @SupaJoon has a PR open for this if you didn't know, so may want to work that out between you guys!

@ybrill
Copy link
Contributor Author

ybrill commented Nov 1, 2023

Thanks @minnakt!
I'll close this PR in favor of @SupaJoon's (after all, his was first 😄).

@ybrill ybrill closed this Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants