This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
DEVPROD-945: Fix toast text for clearing subscriptions #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #13552 ↗︎
Details:
Review all test suite changes for PR #2130 ↗︎ |
|||||||||||||||
sophstad
approved these changes
Oct 31, 2023
sophstad
reviewed
Oct 31, 2023
| `Successfully cleared ${result.clearMySubscriptions} ${pluralize( | ||
| "subscription", | ||
| result.clearMySubscriptions | ||
| )}!` |
There was a problem hiding this comment.
On second thought I feel like the ! in "Success!" is enthusiastic enough
Suggested change
| )}!` | |
| )}.` |
minnakt
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-945
Description
Fixes the toast text for clearing subscriptions.
Also downgrades the build variant / task history page errors to warnings. Added a rule to exclude
"warning"level errors on Sentry so that they won't report to Slack and tested this on staging (the errors will still report on the Sentry dashboard, just not on Slack).Screenshots