DEVPROD-1101: Update previous commits selector #2120
Conversation
sophstad
changed the title
1 failed test on run #13634 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Tests Table > Test Status Selector > Clicking on 'All' checkbox adds all statuses to URL |
Output
Screenshots
Video
|
|
Review all test suite changes for PR #2120 ↗︎
| No previous versions available. | ||
| </Tooltip> | ||
| ) : ( | ||
| <Menu trigger={<Button size={Size.Small}>Previous commits</Button>}> |
There was a problem hiding this comment.
I feel like it might be helpful to have a dropdown caret on the button, otherwise I probably wouldn't assume it has menu options (esp because it's adjacent to buttons that do not have menu options)
| : `There is no version that satisfies this criteria.`} | ||
| </Tooltip> | ||
| )} | ||
| {versionMetadata?.isPatch ? "Base" : "Previous"} commit |
There was a problem hiding this comment.
I think that it's not obvious that these options send you to a different page, which I think could be fixed by just tweaking the menu options to start with "Go to..." or "View..."
| // We don't error for this query because it is the default query that is run when the page loads. | ||
| // If it errors it probably means there is no base version, which is fine. |
There was a problem hiding this comment.
I think you can delete this comment since there's a skip on this now :0 (doesn't run by default)
|
|
||
| return { | ||
| [CommitType.Base]: getTaskRoute(parentTask.id), | ||
| [CommitType.LastPassing]: getTaskRoute( |
There was a problem hiding this comment.
This link would always default to the parent task even if it does not pass
There was a problem hiding this comment.
Sorry if I'm misunderstanding, doesn't this test case assert that the last passing task works correctly?
There was a problem hiding this comment.
Thanks for looping back I missed that!
|
|
||
| return { | ||
| [CommitType.Base]: getTaskRoute(parentTask.id), | ||
| [CommitType.LastPassing]: getTaskRoute( |
There was a problem hiding this comment.
Thanks for looping back I missed that!
| .buildVariants ?? []; | ||
| if (buildVariants.length > 1) { | ||
| reportError( | ||
| new Error("Multiple build variants matched previous commit search.") |
There was a problem hiding this comment.
Is there more info here that we can add to the sentry search? Or will sentry give us the necessary data be default?
There was a problem hiding this comment.
Sentry will include a breadcrumb with the GraphQL query sent before this error. I think that's enough information to start investigating this.
DEVPROD-1101 - This is what I worked on over skunkworks because it's always irked me 😁
Description
Screenshots
Testing