This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
EVG-20048: Introduce check-file plugin #2109
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,7 +28,7 @@ module.exports = { | |
| "plugin:jsdoc/recommended-typescript-error", | ||
| "plugin:prettier/recommended", // Note: prettier must ALWAYS be the last extension. | ||
| ], | ||
| plugins: ["@typescript-eslint", "sort-destructure-keys", "check-file"], | ||
| settings: { | ||
| react: { | ||
| version: "detect", | ||
|
|
@@ -96,6 +96,18 @@ module.exports = { | |
| // Rules for prettier. | ||
| "prettier/prettier": errorIfStrict, // Makes Prettier issues warnings rather than errors. | ||
| "sort-destructure-keys/sort-destructure-keys": errorIfStrict, | ||
| "check-file/filename-naming-convention": [ | ||
| "warn", | ||
| { | ||
| "**/*.graphql": "KEBAB_CASE", | ||
| "cypress/integration/**/*.ts": "SNAKE_CASE", | ||
| "scripts/**/*.{js,ts}": "KEBAB_CASE", | ||
| "src/**/*.{js,ts}": "CAMEL_CASE", | ||
|
There was a problem hiding this comment. You can use e.g. Checkout for an easy way to test out glob match rules. |
||
| }, | ||
|
There was a problem hiding this comment. Can we further trim these down? So we don't have 4 different conventions. There was a problem hiding this comment. This is the smallest set that makes sense to me. Let me know what you want to trim and why. |
||
| { | ||
| ignoreMiddleExtensions: true, | ||
| }, | ||
| ], | ||
| }, | ||
| overrides: [ | ||
| // For React Typescript files in src. | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8976,6 +8976,14 @@ eslint-module-utils@^2.7.3: | |
| dependencies: | ||
| debug "^3.2.7" | ||
|
|
||
| [email protected]: | ||
| version "2.6.2" | ||
| resolved "https://registry.yarnpkg.com/eslint-plugin-check-file/-/eslint-plugin-check-file-2.6.2.tgz#2e60d567ce7d087727d19c7e7b5b9def1e5b693e" | ||
| integrity sha512-z3Rur4JjOdNH0fia1IH7JQseo9NLuFVtw9j8P6z2c5XmXWemH7/qGpmMB8XbOt9bJBNpmPlNAGJty9b3EervPw== | ||
| dependencies: | ||
| is-glob "^4.0.3" | ||
| micromatch "^4.0.5" | ||
|
|
||
| eslint-plugin-cypress@^2.12.1: | ||
| version "2.14.0" | ||
| resolved "https://registry.yarnpkg.com/eslint-plugin-cypress/-/eslint-plugin-cypress-2.14.0.tgz#c65e1f592680dd25bbd00c86194ee85fecf59bd7" | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use our constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or alternatively
errorIfStrictis there any reason we wouldn't want to enforce files are consistently named?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using the
WARNflag until all of the problems are resolved and then applyerrorIfStrict? Alternatively we can do them at once but there will be over 42 renamed files and imports.