This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
EVG-20048: Introduce check-file plugin #2109
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
b1ba409
Introduce check-file plugin
SupaJoon a3e406c
verify tsx and use errorIfStrict
SupaJoon 9889520
prodserver -> prod-server
SupaJoon 647483b
cypress files
SupaJoon d54ce57
eventLogDiffs
SupaJoon 87b0510
inactive style
SupaJoon f43cd07
more file name updates
SupaJoon 4976741
toast test
SupaJoon bd90447
update naming conventions
SupaJoon f8ea637
404 -> NotFound
SupaJoon aa95bc4
remove tsx file (replaced by ts file)
SupaJoon 0848548
event copy component
SupaJoon bc5a909
tsx -> ts
SupaJoon 90c44fe
HostEventString comp
SupaJoon 802787e
utils.tsx -> Utils.tsx
SupaJoon 1f66210
ts -> tsx
SupaJoon c1a86a6
tsx -> ts
SupaJoon c8d17f9
update check-file edge cases
SupaJoon ad6d4c0
Merge branch 'main' of github.com:evergreen-ci/spruce into EVG-20048
SupaJoon 59e8c90
Merge branch 'main' of github.com:evergreen-ci/spruce into EVG-20048
SupaJoon 9034003
comments
SupaJoon de7196a
create useSubscriptionData hook file
SupaJoon 827ea8e
merge main
SupaJoon 750a352
update buildbaron file name
SupaJoon 161996b
Divider.tsx -> divider.ts
SupaJoon 916dcad
simplify rules
SupaJoon 998cf28
try and fix error
SupaJoon 1013516
merge main
SupaJoon 8fc1528
Merge branch 'main' of github.com:evergreen-ci/spruce into EVG-20048
SupaJoon bbece55
change dir casing
SupaJoon 33f1d7b
Revert "change dir casing"
SupaJoon 45a7c6e
fix casing
SupaJoon 5defa1c
eslint:fix
SupaJoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...s/Settings/EventLog/EventLogDiffs.test.ts → ...s/Settings/EventLog/eventLogDiffs.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,22 +2,15 @@ import { useMemo } from "react"; | |
import { useQuery } from "@apollo/client"; | ||
import styled from "@emotion/styled"; | ||
import { LeafyGreenTableRow } from "@leafygreen-ui/table"; | ||
import { | ||
getCommitsRoute, | ||
getPatchRoute, | ||
getTaskRoute, | ||
getVersionRoute, | ||
} from "constants/routes"; | ||
import { size } from "constants/tokens"; | ||
import { convertFamilyTrigger } from "constants/triggers"; | ||
import { | ||
GeneralSubscription, | ||
Selector, | ||
UserSubscriptionsQuery, | ||
UserSubscriptionsQueryVariables, | ||
GeneralSubscription, | ||
Selector, | ||
} from "gql/generated/types"; | ||
import { USER_SUBSCRIPTIONS } from "gql/queries"; | ||
import { ResourceType } from "types/triggers"; | ||
|
||
export const useSubscriptionData = () => { | ||
const { data } = useQuery< | ||
|
@@ -108,34 +101,7 @@ const ExpandedBlock = styled.pre` | |
padding: ${size.s} ${size.l}; | ||
`; | ||
|
||
export const getResourceRoute = ( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved this function so this file exports the hook only. |
||
resourceType: ResourceType, | ||
selector: Selector | ||
) => { | ||
const { data: id, type } = selector; | ||
|
||
if (!id) { | ||
return ""; | ||
} | ||
|
||
switch (resourceType) { | ||
case ResourceType.Build: | ||
case ResourceType.Version: { | ||
if (type === "project") { | ||
return getCommitsRoute(id); | ||
} | ||
return getVersionRoute(id); | ||
} | ||
case ResourceType.Patch: | ||
return getPatchRoute(id, { configure: false }); | ||
case ResourceType.Task: | ||
return getTaskRoute(id); | ||
default: | ||
return ""; | ||
} | ||
}; | ||
|
||
export const formatRegexSelectors = (regexSelectors: Selector[]) => ({ | ||
const formatRegexSelectors = (regexSelectors: Selector[]) => ({ | ||
"regex-selectors": regexSelectors.reduce<Record<string, string>>( | ||
(obj, { data, type }) => ({ | ||
...obj, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we further trim these down? So we don't have 4 different conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the smallest set that makes sense to me. Let me know what you want to trim and why.