Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

EVG-20817: Don't invalidate General project settings form based on initial project identifier #2104

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

SupaJoon
Copy link
Contributor

@SupaJoon SupaJoon commented Oct 16, 2023

EVG-20817

Description

This fixes an issue where the General project settings form is disabled when it loads with a project identifier that doesn't pass validation. The form will do normal validation if any changes are made to the project identifier.

@SupaJoon SupaJoon requested a review from a team October 16, 2023 19:32
@cypress
Copy link

cypress bot commented Oct 16, 2023

Passing run #13321 ↗︎

0 601 7 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Don't invalidate form based on initial data
Project: Spruce Commit: 7e19b62390
Status: Passed Duration: 18:45 💡
Started: Oct 16, 2023 7:39 PM Ended: Oct 16, 2023 7:57 PM

Review all test suite changes for PR #2104 ↗︎

Copy link
Contributor

@sophstad sophstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@SupaJoon SupaJoon merged commit 0cab41a into evergreen-ci:main Oct 16, 2023
2 checks passed
@SupaJoon SupaJoon deleted the EVG-20817-fix branch October 16, 2023 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants