Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

EVG-20692: Indicate if a version has been ignored #2095

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

minnakt
Copy link
Contributor

@minnakt minnakt commented Oct 9, 2023

EVG-20692

Description

This PR makes it possible to tell if a version has been ignored on Spruce. Previously, there was no information about ignored versions at all.

Screenshots

Banner on Version page (I used a Banner because the LeafyGreen design docs say Callout should be reserved for docs only):

Screenshot 2023-10-09 at 3 25 06 PM

Icon in the inactive commits tooltip (this is the same icon on the legacy UI, but if it doesn't seem clear enough, I could also just write out IGNORED explicitly):
Screenshot 2023-10-09 at 4 26 55 PM

Testing

  • Cypress tests

Verified

This commit was signed with the committer’s verified signature. The key has expired.
@cypress
Copy link

cypress bot commented Oct 9, 2023

Passing run #13220 ↗︎

0 601 7 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge branch 'main' into EVG-20692
Project: Spruce Commit: 3275c19583
Status: Passed Duration: 18:57 💡
Started: Oct 10, 2023 4:49 PM Ended: Oct 10, 2023 5:08 PM

Review all test suite changes for PR #2095 ↗︎

Verified

This commit was signed with the committer’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
@minnakt minnakt marked this pull request as ready for review October 10, 2023 01:00
@minnakt minnakt requested a review from a team October 10, 2023 01:00
Copy link
Contributor

@SupaJoon SupaJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, another possibility for the eyeball is IGNORED in a badge

Verified

This commit was signed with the committer’s verified signature. The key has expired.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
@minnakt
Copy link
Contributor Author

minnakt commented Oct 10, 2023

LGTM, another possibility for the eyeball is IGNORED in a badge

I really like the badge idea, but when I tried it it seemed a bit too bulky for the tooltip — so I decided to make a custom icon that reads more like "ignored". We can update it if it ends up confusing people, but I just wanted to try it out. 🫣

Screenshot 2023-10-10 at 12 35 08 PM

@minnakt minnakt changed the title EVG-20692: Indicate if a version is ignored EVG-20692: Indicate if a version has been ignored Oct 10, 2023
@minnakt minnakt merged commit 3d68c12 into evergreen-ci:main Oct 10, 2023
2 checks passed
@minnakt minnakt deleted the EVG-20692 branch October 10, 2023 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants