This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
EVG-20201: Use new LeafyGreen props in LoadingButton component #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #13086 ↗︎
Details:
Review all test suite changes for PR #2077 ↗︎ |
|||||||||||||||
SupaJoon
approved these changes
Oct 3, 2023
| @@ -13,7 +13,8 @@ export const LoadingButton: ExtendableBox< | |||
| > = forwardRef(({ leftGlyph, loading = false, ...rest }: Props, ref) => ( | |||
| <LeafyGreenButton | |||
There was a problem hiding this comment.
Could we include LoadingButton in storybook?
sophstad
reviewed
Oct 3, 2023
| @@ -13,7 +13,8 @@ export const LoadingButton: ExtendableBox< | |||
| > = forwardRef(({ leftGlyph, loading = false, ...rest }: Props, ref) => ( | |||
There was a problem hiding this comment.
The type definition above could be tightened up a little bit, I think; it currently includes loading and isLoading. We should probably choose one or the other for clarity.
There was a problem hiding this comment.
oops thanks sophie! I kind of like loading more so I kept that one
sophstad
approved these changes
Oct 4, 2023
minnakt
changed the title
minnakt
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-20201
Description
Updates the
LoadingButtoncomponent to use the native props on the LG button.