EVG-6867: Support searching by git hash on commit history #2073
Conversation
|
I used the feature in staging to find active and inactive commits and it works really well to center a commit. There are some issues around paginating backwards which limits utility since that's probably something that users will want to do after searching. We could merge this in as an experimental feature to see how users utilize jumping to a commit which could help with a future redesign. Since fixing the pagination issue is a major lift, it may be worth collecting analytics and partially meeting users' needs than not meeting them at all. This might be good to discuss at the UI roundtable. |
src/pages/commits/RenderCommit.tsx
Outdated
| if (revision.trim() === "") { | ||
| return false; | ||
| } | ||
| if (version && version.revision.includes(revision)) { |
There was a problem hiding this comment.
| if (version && version.revision.includes(revision)) { | |
| if (version?.revision.includes(revision)) { |
src/pages/commits/RenderCommit.tsx
Outdated
| if ( | ||
| rolledUpVersions && | ||
| rolledUpVersions.some((v) => v.revision.includes(revision)) | ||
| ) { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
| if ( | |
| rolledUpVersions && | |
| rolledUpVersions.some((v) => v.revision.includes(revision)) | |
| ) { | |
| return true; | |
| } | |
| return false; | |
| return rolledUpVersions && rolledUpVersions.some((v) => v.revision.includes(revision)) |
There was a problem hiding this comment.
I kept this one since I think it's easier to read, but I implemented your other feedback
| @@ -70,7 +70,7 @@ export const CommitChart: React.FC<Props> = ({ | |||
| const onToggleAccordion = ({ isVisible }) => | |||
| Cookies.set(COMMIT_CHART_TYPE_VIEW_OPTIONS_ACCORDION, isVisible.toString()); | |||
|
|
|||
| return hasError ? ( | |||
| return noData ? ( | |||
There was a problem hiding this comment.
| return noData ? ( | |
| return !versions ? ( |
Passing run #13927 ↗︎
Details:
Review all test suite changes for PR #2073 ↗︎ |
||||||||||||||||||||
minnakt
requested review from
SupaJoon and
a team
and removed request for
SupaJoon
|
evergreen retry |
minnakt
changed the title
minnakt
changed the title
minnakt
changed the title
EVG-6867
Description
This PR includes the frontend changes to make it possible to jump to a specific commit in the commit history.
Screenshots
commit_history.mov
Testing
search by git commitblock is new)Evergreen PR