EVG-19948: Support EC2 On-Demand on provider settings page #2071
Conversation
Passing run #12987 ↗︎
Details:
Review all test suite changes for PR #2071 ↗︎ |
||||||||||||||||||||
|
evergreen retry |
| }, | ||
| }, | ||
| }, | ||
| ec2OnDemandProviderSettings: { |
There was a problem hiding this comment.
Not sure how fixable this is (or if it needs fixing) but when I switch to EC2 on demand from another provider the card title for the first region is blank
There was a problem hiding this comment.
no problemo, just gotta tweak the transformer :)
| amiId, | ||
| instanceType, | ||
| sshKeyName, | ||
| instanceProfileARN, |
There was a problem hiding this comment.
[nit] The legacy platform mentions that ARN = Amazon Resource Name, so maybe that would be worth including in the description
| cy.contains("Default VPC Subnet ID").should("exist"); | ||
| cy.contains("VPC Subnet Prefix").should("exist"); | ||
|
|
||
| cy.dataCy("use-vpc").uncheck({ force: true }); |
There was a problem hiding this comment.
I don't think it's reliable to use force when making assertions on components related to the test description. Using force prevents testing if the use-vpc button is actually available to click. If use-vpc is disabled or hidden, this code will pass through. I think force usage is okay when setting the page up in a particular state to begin testing because those assertions are less important then.
There was a problem hiding this comment.
Using force is pretty much required for LG checkboxes since they have a styling that makes them hidden and unclickable
| cy.contains("Default VPC Subnet ID").should("not.exist"); | ||
| cy.contains("VPC Subnet Prefix").should("not.exist"); |
There was a problem hiding this comment.
I think it's better to take advantage asserting visibility if showing/hiding is a theme of the test.
| cy.get("@keyNameInput").type("my ssh key"); | ||
| cy.getInputByLabel("User Data").type("<powershell></powershell>"); | ||
| cy.getInputByLabel("Merge with existing user data").check({ | ||
| force: true, |
There was a problem hiding this comment.
It's probably better to not use force here since this test is about form interaction.
There was a problem hiding this comment.
same comment as above
| force: true, | ||
| }); | ||
| save(); | ||
| cy.validateToast("success"); |
There was a problem hiding this comment.
It's helpful to include the toast copy because it helps document the test and leaves a breadcrumb to the hook.
EVG-19948
Description
Adds support for EC2 On-Demand. It's very similar to the EC2 Fleet settings but doesn't have the fleet options section.
I moved stuff around with the
schema&uiSchemain an attempt to make it easier to cross-reference them.Screenshots
Testing
Evergreen PR