This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
EVG-19254: Show details.description regardless of task status #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #13004 ↗︎
Details:
Review all test suite changes for PR #2070 ↗︎ |
|||||||||||||||
minnakt
changed the title
SupaJoon
suggested changes
Sep 29, 2023
src/pages/task/metadata/index.tsx
Outdated
| details.description, | ||
| isContainerTask | ||
| )}` | ||
| : `Command: ${details.description}`} |
There was a problem hiding this comment.
The character limit is 500 according to the docs. I think the text needs to render outside of the metadata panel after a certain character count.
src/pages/task/metadata/index.tsx
Outdated
| details.description, | ||
| isContainerTask | ||
| )}` | ||
| : `Command: ${details.description}`} |
There was a problem hiding this comment.
A possible label is "Status description". It could be good since those words are similar to the docs and API.
There was a problem hiding this comment.
thanks for the suggestion — but I think I might like Command slightly more. 😅
There was a problem hiding this comment.
No problem Command is good too 😎
SupaJoon
approved these changes
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-19254
Description
Users can set the value of
descriptioneven if the task has succeeded (docs), but we only show it if the task has failed. We should show the description if it exists.I wasn't sure what verbiage to use since
descriptioncan be set to anything of the user's choice (or it will default to the last run command), so if you have another suggestion feel free to let me know.Testing