Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

EVG-20818: Remove testIsolation for notification preferences #2063

Merged
merged 2 commits into from
Sep 27, 2023
Merged

EVG-20818: Remove testIsolation for notification preferences #2063

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
107a6d5
Remove testIsolation flag
sophstad Sep 26, 2023
54daebd
Remove lint warnings
sophstad Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cypress/integration/preferences/notifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ describe("global subscription settings", () => {
"aria-disabled",
"true"
);
cy.dataCy("slack-member-id-field").clear().type("12345");
cy.dataCy("slack-member-id-field").clear();
cy.dataCy("slack-member-id-field").type("12345");
Comment on lines +11 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cy.dataCy("save-profile-changes-button").should(
"not.have.attr",
"aria-disabled",
Expand All @@ -17,7 +18,8 @@ describe("global subscription settings", () => {
});
it("saving changes to a field should work", () => {
cy.visit(pageRoute);
cy.dataCy("slack-username-field").clear().type("slack.user");
cy.dataCy("slack-username-field").clear();
cy.dataCy("slack-username-field").type("slack.user");
cy.dataCy("save-profile-changes-button").click();
cy.validateToast("success", "Your changes have successfully been saved.");
});
Expand Down Expand Up @@ -73,7 +75,7 @@ describe("user subscriptions table", () => {
);
});

describe("Deleting subscriptions", { testIsolation: false }, () => {
describe("Deleting subscriptions", () => {
it("Deletes a single subscription", () => {
cy.dataCy("subscription-row")
.eq(0)
Expand Down