This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
EVG-20833 Update modal to latest version #2039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #12724 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
minnakt
approved these changes
Sep 15, 2023
package.json
Outdated
| @@ -78,9 +78,9 @@ | |||
| "@leafygreen-ui/interaction-ring": "7.0.2", | |||
| "@leafygreen-ui/leafygreen-provider": "3.1.0", | |||
| "@leafygreen-ui/loading-indicator": "2.0.5", | |||
| "@leafygreen-ui/marketing-modal": "^4.0.5", | |||
| "@leafygreen-ui/marketing-modal": "^4.1.0", | |||
There was a problem hiding this comment.
actually we do not use this dep I think! delete?
| @@ -8,14 +8,16 @@ describe("Name change modal", () => { | |||
| cy.contains(originalName); | |||
| cy.dataCy("name-change-modal-trigger").click(); | |||
| const newName = "a different name"; | |||
| cy.get("textarea").clear().type(newName); | |||
| @@ -0,0 +1,16 @@ | |||
| // https://github.com/focus-trap/tabbable#testing-in-jsdom | |||
There was a problem hiding this comment.
makes me so sad 😭 ... btw, do we want to try to consolidate it with the other focus-trap mock so they're in the same file?
There was a problem hiding this comment.
good call moved it to the mocks directory so they get picked up by jest
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-20833
Description
Breaking this out of #2037 since menu appears to be breaking the tests