This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
EVG-19954: Force save when changing providers #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #12716 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
SupaJoon
reviewed
Sep 11, 2023
| @@ -12,4 +12,48 @@ describe("using the distro dropdown", () => { | |||
| cy.location("pathname").should("not.contain", "localhost"); | |||
| cy.location("pathname").should("contain", "rhel71-power8-large"); | |||
| }); | |||
|
|
|||
| it("warns when navigating away from distro settings with unsaved changes and allows returning to distro settings", () => { | |||
There was a problem hiding this comment.
nit: It may be more organized to put these tests under a describe statement labeled "Warning modal"
Comment on lines
28
to
29
| Because you have modified the distro provider, your changes must be | ||
| saved before navigating to a new page. |
There was a problem hiding this comment.
Suggested change
| Because you have modified the distro provider, your changes must be | |
| saved before navigating to a new page. | |
| Your distro provider changes must be saved or reverted before navigating to a new page. |
| }); | ||
|
|
||
| const handleSave = () => { | ||
| // Only perform the save operation is the tab is valid. |
There was a problem hiding this comment.
Suggested change
| // Only perform the save operation is the tab is valid. | |
| // Only perform the save operation if the tab is valid. |
| const handleSave = () => { | ||
| // Only perform the save operation is the tab is valid. | ||
| // eslint-disable-next-line no-prototype-builtins | ||
| if (formToGqlMap.hasOwnProperty(tab)) { |
There was a problem hiding this comment.
This kind of implies that the modal may appear when it's not supposed to. Do you know how to get it in that state -- I wasn't able to.
There was a problem hiding this comment.
Interestingly, omitting this check introduces a CodeQL error. You can see that here: #2014 (review)
Edit: looks like using Object.prototype introduces the same problem!
SupaJoon
suggested changes
Sep 11, 2023
Comment on lines
+73
to
+74
| // eslint-disable-next-line no-prototype-builtins | ||
| if (formToGqlMap.hasOwnProperty(tab)) { |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line no-prototype-builtins | |
| if (formToGqlMap.hasOwnProperty(tab)) { | |
| if (Object.prototype.hasOwnProperty.call(formToGqlMap, tab) { |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SupaJoon
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-19954
Description
Screenshots
Testing