Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

EVG-20606 Display an error for previous commit selector #2022

Merged
merged 6 commits into from
Sep 7, 2023

Conversation

khelif96
Copy link
Contributor

@khelif96 khelif96 commented Sep 5, 2023

EVG-20606

Description

Occasionally these queries would silently error in the background leading to a confusing state. This displays an error modal if they do not load.

Screenshots

image

@khelif96 khelif96 requested a review from a team September 5, 2023 21:17
@cypress
Copy link

cypress bot commented Sep 5, 2023

Passing run #12495 ↗︎

0 573 7 0 Flakiness 0

Details:

Use index export
Project: Spruce Commit: 8a5b4400c8
Status: Passed Duration: 16:35 💡
Started: Sep 6, 2023 6:06 PM Ended: Sep 6, 2023 6:23 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@@ -74,6 +79,9 @@ export const PreviousCommits: React.FC<PreviousCommitsProps> = ({ taskId }) => {
task: getTaskFromMainlineCommitsQuery(data),
});
},
onError: (err) => {
dispatchToast.error(`Error fetching last passing task: '${err.message}'`);
Copy link
Contributor

@SupaJoon SupaJoon Sep 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can help the user more to correlate this error with the the actual Go to last passing version dropdown option. Some ideas are updating the error copy to match the dropdown option, disabling the option from the menu or adding a tooltip to Go to indicate that the option is unavailable and not loading.

Suggested change
dispatchToast.error(`Error fetching last passing task: '${err.message}'`);
dispatchToast.error(`Last passing version unavailable: '${err.message}'`);

@khelif96 khelif96 requested a review from SupaJoon September 6, 2023 17:43
@khelif96 khelif96 added this pull request to the merge queue Sep 7, 2023
Merged via the queue into evergreen-ci:main with commit 8044005 Sep 7, 2023
2 checks passed
@khelif96 khelif96 deleted the EVG-20606 branch September 7, 2023 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants