Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

EVG-20650 Add unscheduleDownstreamVersions to Spruce #2020

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

hadjri
Copy link
Contributor

@hadjri hadjri commented Sep 5, 2023

EVG-20650

Description

Adding a "Unschedule Downstream Versions" checkbox to the project triggers field in Spruce now that resolvers are supported with this field on the Evergreen side

Testing

Tested in staging and modified unit tests here.

Evergreen PR

evergreen-ci/evergreen#6968

@cypress
Copy link

cypress bot commented Sep 5, 2023

Passing run #12469 ↗︎

0 573 7 0 Flakiness 0

Details:

CR
Project: Spruce Commit: 2d237b91ce
Status: Passed Duration: 17:01 💡
Started: Sep 5, 2023 8:26 PM Ended: Sep 5, 2023 8:43 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@hadjri hadjri requested a review from a team September 5, 2023 14:48
@hadjri
Copy link
Contributor Author

hadjri commented Sep 5, 2023

Porting over from #2013 due to merge conflict issues that I wasn't able to solve

Copy link
Contributor

@khelif96 khelif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@SupaJoon SupaJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the recommended change

"ui:description":
"Downstream versions created by this trigger will be deactivated by default",
"ui:optional": true,
"ui:bold": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying component doesn't accept this parameter yet and will default it to false. You can add it in by making changes to 2 other files besides this one shown in this commit

@hadjri hadjri added this pull request to the merge queue Sep 6, 2023
Merged via the queue into evergreen-ci:main with commit b910281 Sep 6, 2023
2 checks passed
@hadjri hadjri deleted the EVG-20650-1 branch September 6, 2023 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants