This repository has been archived by the owner on Jul 2, 2024. It is now read-only.
EVG-20320: Upload Sentry source maps #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #12464 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
SupaJoon
suggested changes
Sep 5, 2023
| name: process.env.npm_package_version, | ||
| }, | ||
| sourcemaps: { | ||
| assets: "./build/assets/*", |
There was a problem hiding this comment.
It looks like from the upload link that minified files are being uploaded alongside the minified files. I think this suggestion might do the trick to limit that
Suggested change
| assets: "./build/assets/*", | |
| assets: "./build/assets/*.map", |
There was a problem hiding this comment.
The minified files should be uploaded with the sourcemaps! As per the docs:
For Sentry to de-minify your stack traces you must provide both the minified files (for example, app.min.js) and the corresponding source maps.
SupaJoon
approved these changes
Sep 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EVG-20320
Description
release.injectoption utilized by the plugin, it's no longer necessary to passAPP_VERSIONwhen initializing Sentry..env-cmdrc.jsonwith the Sentry auth token for review (will update the 1Password vault when this PR is approved)Testing