Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Commit

Permalink
DEVPROD-1905: Upgrade @leafygreen-ui/select to v11.1.1 (#2192)
Browse files Browse the repository at this point in the history
  • Loading branch information
SupaJoon authored Dec 19, 2023
1 parent 494651f commit d72fd8b
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 43 deletions.
2 changes: 1 addition & 1 deletion cypress/integration/spawn/host.ts
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ describe("Navigating to Spawn Host page", () => {
cy.dataCy("distro-option-ubuntu1804-workstation")
.should("be.visible")
.click();
cy.dataCy("volume-select").should("be.disabled");
cy.dataCy("volume-select").should("have.attr", "aria-disabled", "true");
});

it("Clicking 'Add new key' hides the key name dropdown and shows the key value text area", () => {
Expand Down
2 changes: 1 addition & 1 deletion cypress/integration/spawn/volume.ts
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ describe("Spawn volume page", () => {
).click();
cy.dataCy("distro-input").click();
cy.dataCy("distro-option-ubuntu1804-workstation").click();
cy.dataCy("region-select").should("be.disabled");
cy.dataCy("region-select").should("have.attr", "aria-disabled", "true");
cy.dataCy("migrate-modal").contains("Next").click({ force: true });
cy.dataCy("migrate-modal")
.contains("Migrate Volume")
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"@leafygreen-ui/radio-group": "10.1.1",
"@leafygreen-ui/search-input": "2.0.8",
"@leafygreen-ui/segmented-control": "8.2.6",
"@leafygreen-ui/select": "10.2.0",
"@leafygreen-ui/select": "11.1.1",
"@leafygreen-ui/side-nav": "14.0.3",
"@leafygreen-ui/skeleton-loader": "1.1.0",
"@leafygreen-ui/table": "12.1.4",
Expand Down
1 change: 0 additions & 1 deletion src/components/Hosts/UpdateStatusModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ export const UpdateStatusModal: React.FC<Props> = ({
);
};

// @ts-expect-error
const StyledSelect = styled(Select)`
margin-bottom: ${size.xs};
`;
Expand Down
1 change: 0 additions & 1 deletion src/components/PageSizeSelector/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ const PageSizeSelector: React.FC<Props> = ({ onChange, value, ...rest }) => (
</StyledSelect>
);

// @ts-expect-error
const StyledSelect = styled(Select)`
width: 120px;
`;
Expand Down
1 change: 0 additions & 1 deletion src/components/TupleSelect/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ const LabelContainer = styled.div`
flex-direction: row;
`;

// @ts-expect-error
const GroupedSelect = styled(Select)`
width: 30%;
/* overwrite lg borders https://jira.mongodb.org/browse/PD-1995 */
Expand Down
5 changes: 4 additions & 1 deletion src/pages/spawn/spawnVolume/SpawnVolumeModal.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ describe("spawnVolumeModal", () => {
);
expect(screen.queryByDataCy("type-select")).toHaveTextContent("gp2");
expect(screen.queryByLabelText("Never expire")).not.toBeChecked();
expect(screen.queryByDataCy("host-select")).toBeDisabled();
expect(screen.queryByDataCy("host-select")).toHaveAttribute(
"aria-disabled",
"true"
);
expect(screen.queryByText("No hosts available.")).toBeVisible();
});

Expand Down
53 changes: 17 additions & 36 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3229,7 +3229,7 @@
"@leafygreen-ui/tokens" "^2.1.4"
polished "^4.2.2"

"@leafygreen-ui/button@^19.0.1", "@leafygreen-ui/button@^19.0.4":
"@leafygreen-ui/button@^19.0.1":
version "19.0.4"
resolved "https://registry.yarnpkg.com/@leafygreen-ui/button/-/button-19.0.4.tgz#f94ea61608e56020358ac3f8cd66669f125dff64"
integrity sha512-T72lmAHS63cvhyAKaO53tNysL3xDsjnmIoaP0I55eOFOYlEy522U7vf0RMi/BsOePyAJak+x9yZ4uj8AWMCsbg==
Expand Down Expand Up @@ -3863,24 +3863,25 @@
lodash "^4.17.21"
polished "^4.2.2"

"@leafygreen-ui/select@10.2.0":
version "10.2.0"
resolved "https://registry.yarnpkg.com/@leafygreen-ui/select/-/select-10.2.0.tgz#d5c9dd7ca6ec4f043cda45c07c7c5fad89505543"
integrity sha512-w0/XSmN0O85jIahBxgpqGncR0b7R9As4+TNenHe0ULmEwsV1cKpNGt5qXlRyzh6dO7vYKcuSGGhvZW9fCuU/xQ==
"@leafygreen-ui/select@11.1.1", "@leafygreen-ui/select@^11.1.0":
version "11.1.1"
resolved "https://registry.yarnpkg.com/@leafygreen-ui/select/-/select-11.1.1.tgz#b4d03071837feca1d5c206b36a1018b7d936f43f"
integrity sha512-aH0RNrIF3EU+5ChHJxVVjzlmFGkYRTq9DTRqm9eWgWcZIT3+ggIJCOwBNMr/8rD72NhyXm+RD8Gp2wwk8XJJrg==
dependencies:
"@leafygreen-ui/button" "^19.0.4"
"@leafygreen-ui/emotion" "^4.0.3"
"@leafygreen-ui/hooks" "^7.3.3"
"@leafygreen-ui/icon" "^11.12.4"
"@leafygreen-ui/lib" "^10.0.0"
"@leafygreen-ui/palette" "^3.4.7"
"@leafygreen-ui/popover" "^11.0.4"
"@leafygreen-ui/tokens" "^2.0.0"
"@leafygreen-ui/typography" "^16.0.0"
"@types/react-is" "^17.0.0"
"@leafygreen-ui/button" "^21.0.10"
"@leafygreen-ui/emotion" "^4.0.7"
"@leafygreen-ui/hooks" "^8.0.1"
"@leafygreen-ui/icon" "^11.25.0"
"@leafygreen-ui/input-option" "^1.0.13"
"@leafygreen-ui/lib" "^13.0.0"
"@leafygreen-ui/palette" "^4.0.7"
"@leafygreen-ui/popover" "^11.1.1"
"@leafygreen-ui/tokens" "^2.2.0"
"@leafygreen-ui/typography" "^18.0.1"
"@types/react-is" "^18.0.0"
lodash "^4.17.21"
polished "^4.1.3"
react-is "^17.0.1"
react-is "^18.0.1"

"@leafygreen-ui/select@^10.1.0", "@leafygreen-ui/select@^10.3.12":
version "10.3.12"
Expand All @@ -3901,26 +3902,6 @@
polished "^4.1.3"
react-is "^17.0.1"

"@leafygreen-ui/select@^11.1.0":
version "11.1.1"
resolved "https://registry.yarnpkg.com/@leafygreen-ui/select/-/select-11.1.1.tgz#b4d03071837feca1d5c206b36a1018b7d936f43f"
integrity sha512-aH0RNrIF3EU+5ChHJxVVjzlmFGkYRTq9DTRqm9eWgWcZIT3+ggIJCOwBNMr/8rD72NhyXm+RD8Gp2wwk8XJJrg==
dependencies:
"@leafygreen-ui/button" "^21.0.10"
"@leafygreen-ui/emotion" "^4.0.7"
"@leafygreen-ui/hooks" "^8.0.1"
"@leafygreen-ui/icon" "^11.25.0"
"@leafygreen-ui/input-option" "^1.0.13"
"@leafygreen-ui/lib" "^13.0.0"
"@leafygreen-ui/palette" "^4.0.7"
"@leafygreen-ui/popover" "^11.1.1"
"@leafygreen-ui/tokens" "^2.2.0"
"@leafygreen-ui/typography" "^18.0.1"
"@types/react-is" "^18.0.0"
lodash "^4.17.21"
polished "^4.1.3"
react-is "^18.0.1"

"@leafygreen-ui/[email protected]":
version "14.0.3"
resolved "https://registry.yarnpkg.com/@leafygreen-ui/side-nav/-/side-nav-14.0.3.tgz#cf356dc7733e80bef88c4e33a5623c1ea028f748"
Expand Down

0 comments on commit d72fd8b

Please sign in to comment.